AnantLabs / codesmith

Automatically exported from code.google.com/p/codesmith
1 stars 0 forks source link

CSLA - ReadOnlyListBase generated Silverlight Synchronous Factory Methods for GetAll has broken syntax #404

Closed GoogleCodeExporter closed 9 years ago

GoogleCodeExporter commented 9 years ago
CSLA - ReadOnlyListBase generated Silverlight Asynchronous Factory Methods have 
broken syntax

What steps will reproduce the problem?
1. Generate a ReadOnlyListBase with Silverlight enabled
2.
3.

What is the expected output? What do you see instead?

In the BusinessClassName GetAll method, the DataPortal.Fetch looks like:
            return DataPortal.Fetch< CustomerInfoList(new CustomerCriteria());

But should have been:
            return DataPortal.Fetch< CustomerInfoList >(new CustomerCriteria());

The Class ending " >" is missing.

What version of the product are you using?
CodeSmith: v5.2.1, CSLA Templates: v2.0.1.1689, CSLA Framework: v4.0.0.

Please provide any additional information below.

This can be fixed by changing 
CSLA\CSharp\BusinessLayer\Internal\ReadOnlyList.Generated.cst line 79 from
            return DataPortal.Fetch< <%= BusinessClassName %><%= Entity.GenericProperty %>(new <%= ChildBusinessClassName %>Criteria<%= Entity.GenericProperty %>());

to
            return DataPortal.Fetch< <%= BusinessClassName %><%= Entity.GenericProperty %> >(new <%= ChildBusinessClassName %>Criteria<%= Entity.GenericProperty %>());

The " >" might go after the BusinessClassName close tag, I'm honestly not sure 
as I'm still learning this. :)

Original issue reported on code.google.com by coulte...@gmail.com on 12 Jun 2010 at 4:31

GoogleCodeExporter commented 9 years ago
Hello,

This has been fixed in revision 1699.

Thanks
-Blake Niemyjski

Original comment by bniemyjski on 15 Jun 2010 at 12:07

GoogleCodeExporter commented 9 years ago

Original comment by bniemyjski on 21 Jun 2010 at 8:10