search

AnantLabs / gmodel

Automatically exported from code.google.com/p/gmodel
0 stars 0 forks source link

The commit button never seems to be enabled despite additions / edits being made with the editor #14

Open GoogleCodeExporter opened 9 years ago

GoogleCodeExporter commented 9 years ago 
What steps will reproduce the problem?
1. Attempt to make a change in the editor, e.g., "Instantiate" a new artefact / 
edit an existing artefact's payload / create a Visibility

What is the expected output? What do you see instead?
The commit button is not enabled, although I expected it to be, despite the 
word "Changed" being written to System.err, and despite something appearing to 
change in the editor window

This is important to be able to understand how to control the enablement / 
disablement of the "rollback" button (for issue 10). The same logic should be 
used to enable the "rollback" and "commit" buttons -- enabled when the 
changeset is non-empty, and disabled when it is empty.

Original issue reported on code.google.com by a.shewr...@gmail.com on 11 Oct 2011 at 9:46

GoogleCodeExporter commented 9 years ago 
Confirmed that this works in latest deployment (October 18th)

Original comment by a.shewr...@gmail.com on 18 Oct 2011 at 9:07

GoogleCodeExporter commented 9 years ago 
The commit button works the first time, but then is never enabled after that.

Original comment by a.shewr...@gmail.com on 18 Oct 2011 at 9:09

GoogleCodeExporter commented 9 years ago 
Server side request to enable the button (no error is found there) is not 
always delivered to the client-side even with explicit requests to repaint the 
button.
This behavior differs across browser types.
IE - FF - Chrome all had different outcomes.

Need to investigate further

Original comment by ckim...@gmail.com on 19 Oct 2011 at 8:43

GoogleCodeExporter commented 9 years ago 
[deleted comment]
GoogleCodeExporter commented 9 years ago 
[deleted comment]
GoogleCodeExporter commented 9 years ago 
Repaint call can be pushed to the client, 
e.g. with https://vaadin.com/directory/-/directory/addon/icepush
ICEPush worked fine with Chrome, IE8 but not with FF5 > as stated on the page.

Original comment by ckim...@gmail.com on 21 Oct 2011 at 8:37

GoogleCodeExporter commented 9 years ago 
Hi Chul,

Can we use ICEPush to solve this (admittedly for selected browsers only)? I 
think it is better that we have this working for some browsers than for none at 
all. We can create another issue which we address later for fixing this for 
later versions of Firefox.

Solving this as above would provide a reliable way to implement issue 10 as 
well.

Original comment by a.shewr...@gmail.com on 21 Oct 2011 at 6:43

GoogleCodeExporter commented 9 years ago

Original comment by a.shewr...@gmail.com on 21 Oct 2011 at 6:43

GoogleCodeExporter commented 9 years ago 
Thanks Chul, that was fast :) Are you confident that this will work on all 
supported browsers?

Original comment by a.shewr...@gmail.com on 21 Oct 2011 at 7:28

GoogleCodeExporter commented 9 years ago 
calling the main update method by getApplication() resolves this issue:
Ideally a GWT Event bus like solution should be sought.

https://vaadin.com/book/-/page/advanced.global.html

Original comment by ckim...@gmail.com on 23 Oct 2011 at 3:27

GoogleCodeExporter commented 9 years ago 
This issue was two-fold:

G.goLiveWithGmodelEditor() was not called at the end of bootstrapping (local 
development mode)

PropertyChangeListener based event bus does not work reliably with Vaadin

Original comment by ckim...@gmail.com on 23 Oct 2011 at 3:30

GoogleCodeExporter commented 9 years ago

Original comment by jorn.bet...@gmail.com on 3 Nov 2011 at 11:41

GoogleCodeExporter commented 9 years ago

Original comment by jorn.bet...@gmail.com on 3 Nov 2011 at 11:44