AnanthVivekanand / spotify-adblock

Blocking ads on desktop Spotify, crazy code ahead
GNU General Public License v3.0
275 stars 31 forks source link

Logout, Friends list, among others not working. #33

Closed CharlieS1103 closed 3 years ago

CharlieS1103 commented 3 years ago

On logout you recieve : Uncaught (in promise) Error: POST request to sp://desktop/v1/logout failed with status code 404 at c.onSuccess (xpui.js:1) at onSuccess (xpui.js:1)

UpgradeStatus for friends list: xpui.js:1 Error: SUB request to sp://desktop/v1/upgrade/status failed with status code 404 at c.onSuccess (xpui.js:1) at onSuccess (xpui.js:1) n @ xpui.js:1 onSuccess @ xpui.js:1 onSuccess @ xpui.js:1 xpui.js:1 Uncaught (in promise) Error: P

AnanthVivekanand commented 3 years ago

Where are these errors occurring? Are these in the Spotify log or mitm.js log?

CharlieS1103 commented 3 years ago

@AnanthVivekanand These errors are in the spotify console, would you like me to send mitm.js log as well?

CharlieS1103 commented 3 years ago
Screen Shot 2021-06-23 at 6 44 40 PM
CharlieS1103 commented 3 years ago
Screen Shot 2021-06-23 at 6 45 27 PM
CharlieS1103 commented 3 years ago

Believe it or not, atm nothing that requires a connection at all is working, probably not a bug with this but would appreciate any help with why this is happening

AnanthVivekanand commented 3 years ago

Could you start from a fresh git clone and paste a full log of how you set everything up?

CharlieS1103 commented 3 years ago

@AnanthVivekanand I don't think it's an issue with your app, I figured it out(proxy settings randomly reset.) My setup is spicetify with some custom themes and extensions set up, and I then wrote a script to toggle remove ads, wrapped that in a separate Spotify app(on mac.) for convenience, If it happens again I can always write a small script for recurrently checking the settings, however Logout and Friends list still don't work, which I believe is an issue with the spotify ad block.

CharlieS1103 commented 3 years ago

It seems to break whenever I hit the logout button, reset the proxy settings and such

CharlieS1103 commented 3 years ago

It works fine when spicetify is not applied, sorry for the trouble, I'll contact @khanas about it

AnanthVivekanand commented 3 years ago

Ok, I wonder why spicetify conflicts with this. Please share any info if you discover anything.

CharlieS1103 commented 3 years ago

@AnanthVivekanand Will do, I think it's probably something where preferences are saved based on the user signed in so when I log out the proxy settings are reset and I'm unable to log in, I'm going to look into a way to set the default preferences

CharlieS1103 commented 3 years ago

@AnanthVivekanand Yeah, I think that Spicetify actually doesn't conflict, but using Spicetify restore backup (resets proxy settings)will fix the issue however you won't be able to log out. I'm confused on a way to fix this other than just stopping your proxy to log out which would be annoying but not impossible, you could potentially implement something to fix this, although I'm not sure what.

CharlieS1103 commented 3 years ago

The proxy is still up on my computer even after I close the wrapper too which I find odd, I can't even find it in the processes

CharlieS1103 commented 3 years ago
Applications/SpotifyReal.app/Contents/MacOS/SpotifyReal ; exit;
Proxy is up on port 8082
2021-06-23 19:48:24.378 Spotify[2429:21432] This NSLayoutConstraint is being configured with a constant that exceeds internal limits.  A smaller value will be substituted, but this problem should be fixed. Break on BOOL _NSLayoutConstraintNumberExceedsLimit(void) to debug.  This will be logged only once.  This may break in the future.
Allowing: login5.spotify.com
Allowing: apresolve.spotify.com
Allowing: guc3-accesspoint-a-n4f7.ap.spotify.com
Allowing: guc-dealer.spotify.com
Allowing: guc-spclient.spotify.com
Blocked: https://spclient.wg.spotify.com/ads/v2/config?payload=eyJ1c2VyX2FnZW50IjoiTW96aWxsYVwvNS4wIChNYWNpbnRvc2g7IEludGVsIE1hYyBPUyBYIDEwXzE1XzcpIEFwcGxlV2ViS2l0XC81MzcuMzYgKEtIVE1MLCBsaWtlIEdlY2tvKSBDaHJvbWVcLzM2LjAuMTk0NC4wIFNhZmFyaVwvNTM3LjM2IFNwb3RpZnlcLzExNjAwMDY3MiAoOTsgMDsgMikiLCJzZXNzaW9uX2lkIjoiZGMyYjgyYmUtMTNkZi00OGY2LWEyYmYtZWEwNGU0NmE2YTA2In0=
Allowing: api-partner.spotify.com
Blocked: https://spclient.wg.spotify.com/ads/v2/config?payload=eyJ1c2VyX2FnZW50IjoiTW96aWxsYVwvNS4wIChNYWNpbnRvc2g7IEludGVsIE1hYyBPUyBYIDEwXzE1XzcpIEFwcGxlV2ViS2l0XC81MzcuMzYgKEtIVE1MLCBsaWtlIEdlY2tvKSBDaHJvbWVcLzM2LjAuMTk0NC4wIFNhZmFyaVwvNTM3LjM2IFNwb3RpZnlcLzExNjAwMDY3MiAoOTsgMDsgMikiLCJzZXNzaW9uX2lkIjoiZGMyYjgyYmUtMTNkZi00OGY2LWEyYmYtZWEwNGU0NmE2YTA2In0=
Allowing: xpui.app.spotify.com
Error: getaddrinfo ENOTFOUND xpui.app.spotify.com
    at GetAddrInfoReqWrap.onlookup [as oncomplete] (dns.js:66:26) {
  errno: 'ENOTFOUND',
  code: 'ENOTFOUND',
  syscall: 'getaddrinfo',
  hostname: 'xpui.app.spotify.com'
}
Blocked: https://spclient.wg.spotify.com/ads/v2/config?payload=eyJ1c2VyX2FnZW50IjoiTW96aWxsYVwvNS4wIChNYWNpbnRvc2g7IEludGVsIE1hYyBPUyBYIDEwXzE1XzcpIEFwcGxlV2ViS2l0XC81MzcuMzYgKEtIVE1MLCBsaWtlIEdlY2tvKSBDaHJvbWVcLzM2LjAuMTk0NC4wIFNhZmFyaVwvNTM3LjM2IFNwb3RpZnlcLzExNjAwMDY3MiAoOTsgMDsgMikiLCJzZXNzaW9uX2lkIjoiZGMyYjgyYmUtMTNkZi00OGY2LWEyYmYtZWEwNGU0NmE2YTA2In0=
Blocked: https://spclient.wg.spotify.com/ads/v2/config?payload=eyJ1c2VyX2FnZW50IjoiTW96aWxsYVwvNS4wIChNYWNpbnRvc2g7IEludGVsIE1hYyBPUyBYIDEwXzE1XzcpIEFwcGxlV2ViS2l0XC81MzcuMzYgKEtIVE1MLCBsaWtlIEdlY2tvKSBDaHJvbWVcLzM2LjAuMTk0NC4wIFNhZmFyaVwvNTM3LjM2IFNwb3RpZnlcLzExNjAwMDY3MiAoOTsgMDsgMikiLCJzZXNzaW9uX2lkIjoiZGMyYjgyYmUtMTNkZi00OGY2LWEyYmYtZWEwNGU0NmE2YTA2In0=
Blocked: https://spclient.wg.spotify.com/ads/v2/config?payload=eyJ1c2VyX2FnZW50IjoiTW96aWxsYVwvNS4wIChNYWNpbnRvc2g7IEludGVsIE1hYyBPUyBYIDEwXzE1XzcpIEFwcGxlV2ViS2l0XC81MzcuMzYgKEtIVE1MLCBsaWtlIEdlY2tvKSBDaHJvbWVcLzM2LjAuMTk0NC4wIFNhZmFyaVwvNTM3LjM2IFNwb3RpZnlcLzExNjAwMDY3MiAoOTsgMDsgMikiLCJzZXNzaW9uX2lkIjoiZGMyYjgyYmUtMTNkZi00OGY2LWEyYmYtZWEwNGU0NmE2YTA2In0=
Blocked: https://spclient.wg.spotify.com/ad-logic/flashpoint
Blocked: https://spclient.wg.spotify.com/ads/v2/config?payload=eyJ1c2VyX2FnZW50IjoiTW96aWxsYVwvNS4wIChNYWNpbnRvc2g7IEludGVsIE1hYyBPUyBYIDEwXzE1XzcpIEFwcGxlV2ViS2l0XC81MzcuMzYgKEtIVE1MLCBsaWtlIEdlY2tvKSBDaHJvbWVcLzM2LjAuMTk0NC4wIFNhZmFyaVwvNTM3LjM2IFNwb3RpZnlcLzExNjAwMDY3MiAoOTsgMDsgMikiLCJzZXNzaW9uX2lkIjoiZGMyYjgyYmUtMTNkZi00OGY2LWEyYmYtZWEwNGU0NmE2YTA2In0=
AnanthVivekanand commented 3 years ago

What is SpotifyReal.app? Is this a modded Spotify?

CharlieS1103 commented 3 years ago

@AnanthVivekanand It's the wrapper I made to run spotify and spotify adblock at the same time and together (So i don't have to see spotify adblock console as well.)