search

AnanthVivekanand / spotify-adblock

Blocking ads on desktop Spotify, crazy code ahead
GNU General Public License v3.0
273 stars 31 forks source link

Update whitelist.js #35

Closed sudface closed 3 years ago

sudface commented 3 years ago

added whitelist to login5.spotify.com

Spotify App wouldn't open otherwise.

sudface commented 3 years ago

I did just encounter an advert now (about 10 minutes in) though, so closed the pull request for now. I'll reopen if I can find a fix/cause.

Edit: Ha, found that Issue #15 and Issue #7 are the same E2: About 30 mins or so in, and I've only encountered that one advert. Looking at the proxy log, login5 hasn't been requested by the spotify app since opening it. E3: Funnily enough, less than 2 minutes after that, I encountered another advert. Something odd however is that it was the exact same ad. Could be something to do with cache? The only requests that are going through are spclient.wg.spotify.com and audio-fa.scdn.co. Also, found this which blocks that url. I'll try it and see if it breaks anything. Nothing's blown up yet.