Songs are grayed - Githubissues

AnanthVivekanand / spotify-adblock

Blocking ads on desktop Spotify, crazy code ahead

GNU General Public License v3.0

269 stars 32 forks source link

Songs are grayed #52

Closed SupLiCatinG closed 2 years ago

SupLiCatinG commented 2 years ago

Still can play audio but cant select song I tried re-installing everything but still no luck

maximko commented 2 years ago

Same for me, audio also stops after 6 seconds of playing. I think it began yesterday or day before.

pickaxe828 commented 2 years ago

I have the same issue also :0

SupLiCatinG commented 2 years ago

Same for me, audio also stops after 6 seconds of playing. I think it began yesterday or day before.

Yeah bean yesterday but i cant play song with spotify connect.

BTW i tried in windows there is a spotify-adblock issue maybe spotify changed url's ?

karelo911 commented 2 years ago

Same issue I'm facing.

AnanthVivekanand commented 2 years ago

I'm looking into this, I noticed the same problem yesterday. I'll try to get a fix out this weekend if I can find one. Likely, the block/allow list just needs to be updated.

SupLiCatinG commented 2 years ago

When song ends spotify starts station but this feature doesnt work with spotify-adblock can this issue solveable too ? It says cannot fetch url:station error 500

p6002 commented 2 years ago

Same here. Before works good.

CharlieS1103 commented 2 years ago

@AnanthVivekanand Seems like this might be the cause

CharlieS1103 commented 2 years ago

https://spclient.wg.spotify.com/playlistextender/extendp/

AnanthVivekanand commented 2 years ago

I think I solved the issue by proxying through all requests on port 4070. I've been listening for about an hour now with no ads.

Can everyone try the branch greyed-out-fix? If there are no ads, I'll merge it into master.

@maximko @karelo911 @pickaxe828 @CharlieS1103 @p6002 @SupLiCatinG

karelo911 commented 2 years ago

@AnanthVivekanand Trying it out. It appears to work fine now.

SupLiCatinG commented 2 years ago

It is totally fine for me now

p6002 commented 2 years ago

I solved the issue by proxying through all requests on port 4070

Whats that mean?

strejda603 commented 2 years ago

This branch works great!

AnanthVivekanand commented 2 years ago

I solved the issue by proxying through all requests on port 4070

Whats that mean?

I noticed requests to made to various IP addresses, not domains, and tested allowing them through (they were previously blocked). I noticed that all of the requests to these IP addresses were on port 4070, so instead of adding them to the whitelist, I added a condition in mitm.js that proxies the request if it occurs on port 4070.

AnanthVivekanand commented 2 years ago

Alright, greyed-out-fix has been merged into master, running git pull should pull the changes.