search

AnanthVivekanand / spotify-adblock

Blocking ads on desktop Spotify, crazy code ahead
GNU General Public License v3.0
273 stars 31 forks source link

Album art for Blends not showing #70

Closed Mahasvan closed 2 years ago

Mahasvan commented 2 years ago
Screenshot 2022-05-28 at 11 20 42 AM

Sample screenshot above. This is the same case in all Blends.

AnanthVivekanand commented 2 years ago

Can you post your terminal output? Specifically, can you highlight the requests that are made when you open the Blends page?

Mahasvan commented 2 years ago

This is the terminal output from around when I open the page image

here's a snippet from a few seconds before and after I open the blend page

Blocked: https://spclient.wg.spotify.com/ad-logic/prefetch
Blocked: https://spclient.wg.spotify.com/ad-logic/prefetch
Blocked: https://spclient.wg.spotify.com/ads/v2/config?payload=eyJ1c2VyX2FnZW50IjoiTW96aWxsYVwvNS4wIChNYWNpbnRvc2g7IEludGVsIE1hYyBPUyBYIDEzXzBfMCkgQXBwbGVXZWJLaXRcLzUzNy4zNiAoS0hUTUwsIGxpa2UgR2Vja28pIENocm9tZVwvMzYuMC4xOTQ0LjAgU2FmYXJpXC81MzcuMzYgU3BvdGlmeVwvMTE4NzAwNjEyICg5OyAwOyAyKSIsInNlc3Npb25faWQiOiJmNGZmZjIxNC03NzhkLTRkMjMtODg3My1kMTEwM2U5MTJkZGUifQ==
Allowing: i.scdn.co, 443
Blocking: blend-playlist-covers.spotifycdn.com, 443
Allowing: i.scdn.co, 443
Allowing: i.scdn.co, 443
Allowing: i.scdn.co, 443
Allowing: i.scdn.co, 443
Allowing: i.scdn.co, 443
Allowing: i.scdn.co, 443
Allowing: i.scdn.co, 443
Blocked: https://spclient.wg.spotify.com/ads/v2/config?payload=eyJ1c2VyX2FnZW50IjoiTW96aWxsYVwvNS4wIChNYWNpbnRvc2g7IEludGVsIE1hYyBPUyBYIDEzXzBfMCkgQXBwbGVXZWJLaXRcLzUzNy4zNiAoS0hUTUwsIGxpa2UgR2Vja28pIENocm9tZVwvMzYuMC4xOTQ0LjAgU2FmYXJpXC81MzcuMzYgU3BvdGlmeVwvMTE4NzAwNjEyICg5OyAwOyAyKSIsInNlc3Npb25faWQiOiJmNGZmZjIxNC03NzhkLTRkMjMtODg3My1kMTEwM2U5MTJkZGUifQ==
Blocked: https://spclient.wg.spotify.com/ad-logic/prefetch
Blocked: https://spclient.wg.spotify.com/ads/v2/config?payload=eyJ1c2VyX2FnZW50IjoiTW96aWxsYVwvNS4wIChNYWNpbnRvc2g7IEludGVsIE1hYyBPUyBYIDEzXzBfMCkgQXBwbGVXZWJLaXRcLzUzNy4zNiAoS0hUTUwsIGxpa2UgR2Vja28pIENocm9tZVwvMzYuMC4xOTQ0LjAgU2FmYXJpXC81MzcuMzYgU3BvdGlmeVwvMTE4NzAwNjEyICg5OyAwOyAyKSIsInNlc3Npb25faWQiOiJmNGZmZjIxNC03NzhkLTRkMjMtODg3My1kMTEwM2U5MTJkZGUifQ==
Blocked: https://spclient.wg.spotify.com/ads/v2/config?payload=eyJ1c2VyX2FnZW50IjoiTW96aWxsYVwvNS4wIChNYWNpbnRvc2g7IEludGVsIE1hYyBPUyBYIDEzXzBfMCkgQXBwbGVXZWJLaXRcLzUzNy4zNiAoS0hUTUwsIGxpa2UgR2Vja28pIENocm9tZVwvMzYuMC4xOTQ0LjAgU2FmYXJpXC81MzcuMzYgU3BvdGlmeVwvMTE4NzAwNjEyICg5OyAwOyAyKSIsInNlc3Npb25faWQiOiJmNGZmZjIxNC03NzhkLTRkMjMtODg3My1kMTEwM2U5MTJkZGUifQ==
Blocked: https://spclient.wg.spotify.com/ads/v2/config?payload=eyJ1c2VyX2FnZW50IjoiTW96aWxsYVwvNS4wIChNYWNpbnRvc2g7IEludGVsIE1hYyBPUyBYIDEzXzBfMCkgQXBwbGVXZWJLaXRcLzUzNy4zNiAoS0hUTUwsIGxpa2UgR2Vja28pIENocm9tZVwvMzYuMC4xOTQ0LjAgU2FmYXJpXC81MzcuMzYgU3BvdGlmeVwvMTE4NzAwNjEyICg5OyAwOyAyKSIsInNlc3Npb25faWQiOiJmNGZmZjIxNC03NzhkLTRkMjMtODg3My1kMTEwM2U5MTJkZGUifQ==
Blocking: update.googleapis.com, 443

(PS: This is with running node mitm.js, as instructed in the readme)

AnanthVivekanand commented 2 years ago

So it seems that Blocking: blend-playlist-covers.spotifycdn.com, 443 is the issue here, and whitelisting the domain should allow it to work.

I added the fixes to a new branch: fix-70. Could you clone that branch and test whether the blends art works now?

Mahasvan commented 2 years ago

Works now, thanks!