I've noticed the current implementation breaks functionality for podcast audio. Looking into the logs, it appears to be due to some podcasts retrieving audio data directly from the publisher's domains.
For example, NPR podcasts send requests to edgeX.pod.npr.org, and New York Times uses nyt.simplecastaudio.com:
Since these domains do not appear in either the whitelist or blacklist, they are blocked by mitm.js.
Seeing as there's no way to possibly whitelist every one of these publisher domains, the only workaround I can think of is to allow unknown domains by default, and update blacklist-mitm.js accordingly whenever an advertisement request slips through. I've added the following domains to the blacklist based on what was previously blocked as an unknown domain that would otherwise now be allowed:
spclient.wg.spotify.com/gabo-receiver-service/** (Spotify user data tracking)
spclient.wg.spotify.com/sponsoredplaylist/** (blocks the "sponsered by" visual ads in playlists)
**/*sentry.io*/** (user data tracking)
**/*googleapis*/** (user data tracking)
**/*doubleclick*/** (ads)
I've been using this updated version for a few weeks now without issues, but welcome any feedback or alternative approach. Thanks so much for maintaining this project!
I've noticed the current implementation breaks functionality for podcast audio. Looking into the logs, it appears to be due to some podcasts retrieving audio data directly from the publisher's domains.
For example, NPR podcasts send requests to![image](https://user-images.githubusercontent.com/15202629/217938223-4a3808aa-5ae9-42b6-8ab3-a2617e0b1db4.png)
edgeX.pod.npr.org
, and New York Times usesnyt.simplecastaudio.com
:Since these domains do not appear in either the whitelist or blacklist, they are blocked by
mitm.js
.Seeing as there's no way to possibly whitelist every one of these publisher domains, the only workaround I can think of is to allow unknown domains by default, and update
blacklist-mitm.js
accordingly whenever an advertisement request slips through. I've added the following domains to the blacklist based on what was previously blocked as an unknown domain that would otherwise now be allowed:spclient.wg.spotify.com/gabo-receiver-service/**
(Spotify user data tracking)spclient.wg.spotify.com/sponsoredplaylist/**
(blocks the "sponsered by" visual ads in playlists)**/*sentry.io*/**
(user data tracking)**/*googleapis*/**
(user data tracking)**/*doubleclick*/**
(ads)I've been using this updated version for a few weeks now without issues, but welcome any feedback or alternative approach. Thanks so much for maintaining this project!