search

AnanthaKN / jquery-in-place-editor

Automatically exported from code.google.com/p/jquery-in-place-editor
Other
0 stars 0 forks source link

PATCH: Addresses issues 21 and 22 #23

Closed GoogleCodeExporter closed 8 years ago

GoogleCodeExporter commented 8 years ago 
This patch provides a stock v1.0.1 with the following functionality:

Issue #21:  allows for options to be in an array (first) OR in a
comma-delimited dataset.  (Works for either one)

Issue #22:  allows the use of hot or speed keys for extended ASCII
characters - define hot_keys in the setup for the element with a
comma-delimited dataset of extended ASCII characters and a selection will
appear below the text field.  Note:  show_buttons must be true so that
clicking the symbols will not cause the field to auto-submit.

An altered version of this plug-in with the changes above is also supplied.

Original issue reported on code.google.com by warp...@gmail.com on 13 Oct 2009 at 7:32

Attachments:

GoogleCodeExporter commented 8 years ago 
I have changes in my copy of the editor at 
<http://haecker.me/trac/browser/open-source/jquery-edit-in-
place/trunk> and included the patch for the array elements.

Original comment by martin.h...@googlemail.com on 14 Feb 2010 at 2:43

GoogleCodeExporter commented 8 years ago 
Do you still need the changes for the hotkey access?

I am rather reluctant to include that in this way as it is a rather specialized 
feature. I am thinking however about 
adding some callbacks to let you participate in the editor creation.

Patches (with tests) welcomed. :-)

Original comment by mhaec...@gmail.com on 23 Mar 2010 at 10:19

GoogleCodeExporter commented 8 years ago 
I don't really need the 2nd one, but the first one is kind of a must - it keeps 
the
code a bit neater, methinks...no?

Original comment by warp...@gmail.com on 26 Mar 2010 at 3:02

GoogleCodeExporter commented 8 years ago 
@warpkat: You mean the possibility to use arrays to specify the select options? 
That is already in v2.0 (and I even 
expanded on what your patch supports to make it even nicer).

Could you please confirm that it works for you?

The hotkeys thing is not in yet and what I was talking about being reluctant to 
add.

So as far as I see this bug should be closable, right?

Original comment by mhaec...@gmail.com on 28 Mar 2010 at 5:03