search

AnanthaKN / jquery-in-place-editor

Automatically exported from code.google.com/p/jquery-in-place-editor
Other
0 stars 0 forks source link

Upgrade to JQuery 1.4.2 #54

Closed GoogleCodeExporter closed 8 years ago

GoogleCodeExporter commented 8 years ago 
Upgrade from JQuery 1.3.8 to 1.4.2. It not works anymore.

What is the expected output? What do you see instead?
When i click to the in-place-editor div it's closing the in-place-editor
without request.

What version of the product are you using? On what operating system?
Ubuntu 10.04, Firefox 3.6.3

Original issue reported on code.google.com by stefanga...@gmail.com on 10 May 2010 at 2:24

GoogleCodeExporter commented 8 years ago 
Ah, thanks for the hint, I'll look into that soon, as we will also be switching 
to jquery 1.4 for our internal app.

Can you provide more information on what exactly is the problem?

Also I'd love to have input on how to best setup a testsuite that covers 
multiple versions of jquery - not sure how 
that is easily possible.

Original comment by mhaec...@gmail.com on 11 May 2010 at 7:44

GoogleCodeExporter commented 8 years ago 
When i get over the div i see that i can edit (color change), but when i click 
to the
div to edit it, the edit-inplace close like i click submit. 

To realize the multiple versions of jquery maybe the easiest way is jquery from 
google:

http://code.google.com/intl/de-DE/apis/ajaxlibs/documentation/index.html#jquery

Thanks

Original comment by stefanga...@gmail.com on 12 May 2010 at 7:08

GoogleCodeExporter commented 8 years ago 
Fixed:

Replace this:
this.dom.html('<form class="inplace_form" style="display: inline; margin: 0; 
padding:
0;"></form>')
            .find('form')
                .append(editorElement)
                .append(buttons_html);

with this
this.dom.html('').append('<form class="inplace_form" style="display: inline; 
margin:
0; padding: 0;"></form>')
            .find('form')
            .append(editorElement)
            .append(buttons_html);

Original comment by stefanga...@gmail.com on 21 May 2010 at 12:19

GoogleCodeExporter commented 8 years ago 
This change looks really not like it should fix the jquery 1.4 support - I've 
tried the plugin with 1.4 today and 
couldn't find any problems so far. (Apart from the fact that 

Could you please provide a reduction for me to look at to see the problem you 
are describing?

Please reopen this issue if there indeed is a problem.

Regards,
Martin

Original comment by mhaec...@gmail.com on 22 May 2010 at 8:02

GoogleCodeExporter commented 8 years ago 
I wanted to write: apart from the fact that three tests broke because the 
hasClass check has become more strict. 
:)

Original comment by mhaec...@gmail.com on 22 May 2010 at 8:03