AnanthaKN / jquery-in-place-editor

Automatically exported from code.google.com/p/jquery-in-place-editor
Other
0 stars 0 forks source link

Edit problem in IE #59

Closed GoogleCodeExporter closed 9 years ago

GoogleCodeExporter commented 9 years ago
What steps will reproduce the problem?
1. open the demo page in IE let's say 8
2. try to edit the first demo field
3. see the undefined error, the new edited text doesn't stay

What is the expected output? What do you see instead?
expected output is the text edited, I see an undefined error, and the old 
text reverts back

What version of the product are you using? On what operating system?
on my application I use Version 2.1.1. It does the same thing.

Please provide any additional information below.
This is happening in IE 7, 8 and I suppose earlier ones too. On other 
browsers it works.
Thanks

Original issue reported on code.google.com by inssomn...@gmail.com on 26 May 2010 at 7:58

GoogleCodeExporter commented 9 years ago
The OS is Windows XP Professional

Original comment by inssomn...@gmail.com on 26 May 2010 at 8:12

GoogleCodeExporter commented 9 years ago
Managed somekind of fix. 
I changed
var callbackArguments = Array.prototype.splice.call(arguments, 1);
to
var callbackArguments = Array.prototype.slice.call(arguments, 1);
(splice to slice)
Seems to behave ok. Please advise if is ok.
Thanks

Original comment by inssomn...@gmail.com on 26 May 2010 at 9:02

GoogleCodeExporter commented 9 years ago
Thanks for spotting that!

I've committed your fix to the repository.

:-)

To further verify the quality (and since I don't have access to native IE 
browsers), could you please check out the full 
project and run the whole testsuite in the IEs you have access to? 

To do so you just need to open /spec/dom.html in those browsers. The tests 
_should_ all be green, but I'd be curious 
to know if there is any breakage.

Thanks in advance!

Original comment by mhaec...@gmail.com on 30 May 2010 at 11:57