AnantharamanLab / VIBRANT

Virus Identification By iteRative ANnoTation
GNU General Public License v3.0
152 stars 38 forks source link

Scikit-learn version issue: suggestion #81

Open ellasiera opened 1 year ago

ellasiera commented 1 year ago

There seem to be several issues related to VIBRANT_setup.ph errors due to installing a wrong version of scikit-learn and python 3.8. Right now the error refers to installing a scikit version lower than 0.21.3, when the actual error usually occurs when installing higher versions, which is confusing. Could you just change the error message to reflect that?

TaekgeunLee1 commented 1 year ago

I have same error! Did you solve this problem?

ellasiera commented 1 year ago

I have same error! Did you solve this problem?

Sorry, I didn't

KrisKieft commented 1 year ago

Hi, yes this just seems to be a reporting issue when verifying the version of scikit-learn. I'd suggested installing the version listed in the README.

lynnetea commented 11 months ago

Did this work for anyone? I have the following message in the log from the -test:

VIBRANT Caution: running a version of Scikit-Learn lower than v0.21.3 will likely cause issues. With pip you can update by running "pip install --upgrade scikit-learn==0.21.3".

I have an updated version of scikit-learn (from conda list): scikit-learn 1.3.2 py311ha25ca4d_2 conda-forge

Please help. I have no idea how to solve this.

haleyhallowell commented 1 month ago

I am also having a similar issue, im not able to install vibrant from bioconda, and am unable to install that specific version of scikit-learn. I've been trying to troubleshoot this issue for about a month with no luck. Are you planning on putting out a new release that updates scikit-learn? i think it would really improve the ease of installation

nelsonruth11 commented 1 month ago

Had the same issue due to incompatible versions of python and scikit.

I downgraded to python=3.7.13, then installed scikit-learn=0.21.3 and vibrant=1.2.1. Ran the VIBRANT_setup.py -test message successfully.