Ananyasingh2002 / Hacktoberfest2023

Join Hacktoberfest 2023: Contribute to open source, learn, and earn rewards. Beginner-friendly. Explore issues, fork, code, and make a global impact. Let's collaborate!
https://ananyasingh2002.github.io/Hacktoberfest2023/
144 stars 1.24k forks source link

Optimize the code #121

Open soubhik-111 opened 11 months ago

soubhik-111 commented 11 months ago

I want to create a file db.json where initially I will add the data and the call the data by using JS Thus you don't need to add data in HTML. Just add it in JSON file.

Why?

No need to do any change in HTML file. Easy to add.

soubhik-111 commented 11 months ago

@Ananyasingh2002 Can we move on to this idea

Ananyasingh2002 commented 11 months ago

Yeah sure!

soubhik-111 commented 11 months ago

Thank you @Ananyasingh2002 Can you assign me

balkishan69 commented 11 months ago

hey @Ananyasingh2002 can u help me out in resolving this issue, like can i add any dummy data in the json file?

balkishan69 commented 11 months ago

hey @Ananyasingh2002 I have resolved the issue where i created a db.json file where i added some dummy data and i created a script.js file where i wrote some code to fetch data from json file. I have created a PR kindly check and merge it, thanks :)

soubhik-111 commented 11 months ago

Hello @Ananyasingh2002 I have optimize the code Can you merge it now

soubhik-111 commented 11 months ago

PR number #167

bsgautam commented 11 months ago

Ok I Will add a JSON file.

Ashima2003 commented 11 months ago

Heyy I want to work on this issue. Please assign it to me.

ShwetaRajputsk commented 11 months ago

can you please assign me?

saku1331 commented 11 months ago

I wish to contribute. Kindly assign this to me.

soubhik-111 commented 11 months ago

Thank you all but it's done and PR is raised

iammadanlal commented 11 months ago

@insanemindsk @soubhik-111 @badal982003 @balkishan69 hacktoberfest accepted link https://github.com/iammadanlal/os_salon_web https://github.com/iammadanlal/os_salon_server