search

Anarios / return-youtube-dislike

Chrome extension to return youtube dislikes
https://returnyoutubedislike.com/
GNU General Public License v3.0
12.32k stars 544 forks source link

Dislike count / metadata showing in Share button #1010

Closed freshgum-bubbles closed 6 months ago

freshgum-bubbles commented 7 months ago

Have you tried to find similar open issues?

Browser

Firefox

Browser Version

v120

Extension or Userscript?

Extension

Extension/Userscript Version

v3.0.0.12

Video link where you see the problem

https://www.youtube.com/watch?v=F8OZTdhoAVo

What happened?

The dislike text shows inside the Share button instead of the dislike button. This seems like a bug.

Examples

image

image

DOM Snapshot

Here's a snapshot of the relevant DOM area, for reference.

image

How to reproduce/recreate?

Use YouTube :P

Will you be available for follow-up questions to help developers diagnose & fix the issue?

Yes

knedl1k commented 7 months ago

Same issue here. Firefox v120, extension v3.0.0.12.

fadster commented 7 months ago

The extension was updated on December 4th but it's still broken.

Qunas101 commented 7 months ago

Damn, I thought they have added a share counter, but this is indeed the number of dislikes.

Firefox v120.0, Extension v3.0.0.12

Wolterhon commented 7 months ago

Same issue. Firefox 120.0.1. At first I thought it was because I opened a VOD with chat enabled, but it appears to affect all videos.

CartltonCrazeIsBackIGuess commented 7 months ago

same issue - Firefox 120.0.1

zPhenomm commented 7 months ago

same issue Firefox v120.0.1 Extension v3.0.0.12

Also I think the bar for the like/dislike ratio should only be under the like/dislike buttons and not extend under the share button. Might be related to the issue.

sabrt00th commented 7 months ago

Same thing's happening to me. Firefox v120.0.1, extension v3.0.0.12. Pretty sure this wasn't an issue before I updated FF, so maybe something changed?

switchmaxfx commented 7 months ago

Having the same issue on 120.0.1 too.

thowtue commented 7 months ago

Same issue here, Firefox 116.0.3

MookyMcSass commented 7 months ago

Same. Firefox 120.0.1

MookyMcSass commented 7 months ago

Same. Firefox 120.0.1

Now fixed I guess

TsukiZero commented 7 months ago

I had to uninstall and reinstall the extension for it to fix it up. Oddly, the Userscript didn't have that bug, it only lacked the bar.

ghost commented 7 months ago

Same issue here, Firefox 120.0.1

Wolterhon commented 7 months ago

It fixed itself. Works fine now

MrKoddy commented 7 months ago

Dislikes are back but after hitting the like or dislike button, the number of dislikes isn't displayed anymore

fadster commented 7 months ago

Dislikes are back but after hitting the like or dislike button, the number of dislikes isn't displayed anymore

Not only that but you actually have to click twice for the dislike to register.

freshgum-bubbles commented 7 months ago

It fixed itself. Works fine now

I believe that's due to it pulling down the selectors for the dislike buttons from a central server, according to the code on GitHub. The dev just needed to change what the server reported.

I'll keep track of this for a little bit and, if it's fixed, I'll close the issue.

fadster commented 7 months ago

It fixed itself. Works fine now

I believe that's due to it pulling down the selectors for the dislike buttons from a central server, according to the code on GitHub. The dev just needed to change what the server reported.

I'll keep track of this for a little bit and, if it's fixed, I'll close the issue.

It did NOT "fix itself". Did you read the comments above yours? Try clicking on the dislike button, see what happens. Leave this issue open until the developer actually fixes it.

Wolterhon commented 7 months ago

It did NOT "fix itself".

It did. Dislikes are now shown next to the dislike button, that was the initial problem and is the main topic of this issue. I am not meant to test everything under the sun before posting a simple comment on an issue. By saying that it worked fine I meant that the dislike count came back to its intended place. I use the dislike button on rare occasions so no wonder I didn't experience the new bug you're talking about.

Did you read the comments above yours?

No.

Leave this issue open until the developer actually fixes it.

It's not even my issue 😭

fadster commented 7 months ago

It did NOT "fix itself".

It did. Dislikes are now shown next to the dislike button, that was the initial problem and is the main topic of this issue. I am not meant to test everything under the sun before posting a simple comment on an issue. By saying that it worked fine I meant that the dislike count came back to its intended place. I use the dislike button on rare occasions so no wonder I didn't experience the new bug you're talking about.

The point is, the feature is still broken.

Leave this issue open until the developer actually fixes it.

It's not even my issue 😭

If you look closely, you'll notice I wasn't replying to you.

Wolterhon commented 7 months ago

If you look closely, you'll notice I wasn't replying to you.

It did NOT "fix itself". Did you read the comments above yours?

You were obviously talking to me at first so yeah.

fadster commented 7 months ago

If you look closely, you'll notice I wasn't replying to you.

It did NOT "fix itself". Did you read the comments above yours?

You were obviously talking to me at first so yeah.

Do you not know how to follow a reply chain?

Wolterhon commented 7 months ago

Do you not know how to follow a reply chain?

Whatever that is in your book. Ability to quote parts of messages is there for a reason.

fadster commented 7 months ago

Do you not know how to follow a reply chain?

Whatever that is in your book. Ability to quote parts of messages is there for a reason.

I included the complete reply chain intentionally. If you're going to comment on public forums, you should learn how quotes are displayed and interpreted.

Wolterhon commented 7 months ago

I included the complete reply chain intentionally. If you're going to comment on public forums, you should learn how quotes are displayed and interpreted.

On forums that I am on when people reply to multiple people they multi-quote. And usually they split them into multiple quotes, sometimes of the same post. Quit this unspoken rules stuff.

fadster commented 7 months ago

On forums that I am on when people reply to multiple people they multi-quote. And usually they split them into multiple quotes, sometimes of the same post. Quit this unspoken rules stuff.

It's not a "rule", it's a matter of correctly parsing the number of vertical bars framing the quote. Anyway, I suggest we drop this, we are polluting the issue at hand.

freshgum-bubbles commented 7 months ago

It fixed itself. Works fine now

I believe that's due to it pulling down the selectors for the dislike buttons from a central server, according to the code on GitHub. The dev just needed to change what the server reported. I'll keep track of this for a little bit and, if it's fixed, I'll close the issue.

It did NOT "fix itself". Did you read the comments above yours? Try clicking on the dislike button, see what happens. Leave this issue open until the developer actually fixes it.

I read them, and it works fine for me. Perhaps you should detail what version of the extension you use, your browser version, and the rest of what the issue template requires, as opposed to polluting the issue with arguments over semantics.

MrKoddy commented 7 months ago

Also the extension doesn't display number of dislikes for shorts

fadster commented 7 months ago

I read them, and it works fine for me.

Good for you! If it doesn't work on all supported platforms, it's still broken. I'll just create another issue. EDIT: Multiple issues regarding this problem already exist.

polluting the issue with arguments over semantics.

Tell that to the other guy.

Moondarker commented 6 months ago

Ohh what a drama. Anyways, please confirm if you still have any issues once you get the v3.0.0.14 update

Anarios commented 6 months ago

Fixed in 3.0.0.14