Anarios / return-youtube-dislike

Chrome extension to return youtube dislikes
https://returnyoutubedislike.com/
GNU General Public License v3.0
12.55k stars 561 forks source link

New Youtube Format Bug #1037

Open n0753w opened 7 months ago

n0753w commented 7 months ago

Have you tried to find similar issues (open or recently closed)?

Browser

MS Edge

Browser Version

Version 121.0.2277.128

Extension or Userscript?

Extension

Extension/Userscript Version

v3.0.0.14

Video link where you see the problem

Any Youtube video

What happened?

The dislike counter doesn't show with the new ugly UI. Is it possible to make a workaround or does this addon only work with the "normal" UI? image

How to reproduce/recreate?

This only happens because of the new UI. If someone else has said UI, then most addons will fail to work.

Will you be available for follow-up questions to help developers diagnose & fix the issue?

Yes

FilipLac commented 7 months ago

I also have the same issue.

cocoKoniQ commented 7 months ago

Can confirm, I have the same issue.

CobaltM commented 6 months ago

yep same issue

greatwolf commented 6 months ago

Same issue here.

CHlLL7 commented 6 months ago

Had the same issue with the new UI but as a workaround: Installing "Enhancer for Youtube" brings back the old UI and Return Youtube dislikes will work again

n0753w commented 6 months ago

CHlLL7

Yeah I also have that extension. It's great. About a week or so ago, the guy who made the YT Enhancer made an update to prevent the ugly ui from occurring, which is great.

Couchy commented 6 months ago

Is this project dead? I could fix the UI, but there's not much point if the backend is also unmaintained.

n0753w commented 6 months ago

Everything is back to normal for now on my side at least. YT likes to dish out experimental formats randomly.

RocketRobz commented 5 months ago

The new format has rolled out recently on my side, and using "Enhancer for Youtube" also restores the dislikes on my side.

FilipLac commented 5 months ago

The new format has rolled out recently on my side, and using "Enhancer for Youtube" also restores the dislikes on my side.

Yes, for me the enhancer also brought back the dislikes, but on firefox based browsers, this plugin was unavailable until recently...

theblackhole commented 5 months ago

This issue has been fixed with the latest release (v3.0.0.16) which is already available for Edge/Chrome in the Chrome Webstore (Firefox soon)

With this new release, there's also a minor issue where the buttons are aligned to the right when the extension is enabled. I provided a fix (#1047) and it should be available in a future update.

Orevin commented 3 months ago

It looks like this issue resurfaced (extension 3.0.0.16)

archon810 commented 3 months ago

Yeah, 3.0.0.16 is indeed not working on the new UI.

leakedmemory commented 3 months ago

Currently I'm on version 3.0.0.14, on LibreWolf 127.0-1, and have the same issue.

leakedmemory commented 3 months ago

I'm trying to solve this issue, but I don't really know where to look. What I found is that the div that contains the number of dislikes it not being rendered in normal screen size, but if you decrease the size of the screen it'll be rendered correctly. Also, if I understood it correctly, the plugin is not even doing anything on normal size, because there's no logs.

Also commented here: #1058

Works fine when screen size is reduced: small

It's bugged with normal screen size: normal

leakedmemory commented 3 months ago

This problem is related to the line 22 of the Extensions/combined/ryd.content-script.js file. With the new layout change, when the screen is in normal size, there's no valid offsetParent, which is evaluated into null and the code never gets inside the if statement.

if (isShorts() || (getButtons()?.offsetParent && isVideoLoaded())) {

This happens because before the change, it would evaluate to a div with id #below, which still exists, but in the primary column. The primary column is the column with the video player and the recommendations below it, and the secondary column is the one with the title, buttons, comments and so on. When the size is shrunk, the secondary column's content goes to the primary column, finally evaluating the getButtons()?.offsetParent to true and running the code inside the statement.

leakedmemory commented 3 months ago

Also when you put the window back in normal size, it happens the bug commented in PR #1047.

valch85 commented 3 months ago

yep, the extension version 3.0.0.16 for the FF doesn't show a dislike count on a new layout =( CleanShot 2024-07-03 at 13 07 41@2x