Closed theblackhole closed 7 months ago
Anarios
commented
7 months ago Thanks!
Could you please format it with prettier, so that there are less formatting changes, and only the actual code changes in PR?
Nevermind, I'll merge it like this and format later, to release it faster.
Anarios
commented
7 months ago Submitted this version for review
Anarios
commented
7 months ago Created a release from this: https://github.com/Anarios/return-youtube-dislike/releases/tag/v3.0.0.15 (wrong link)
Correct link: https://github.com/Anarios/return-youtube-dislike/releases/tag/v3.0.0.16
theblackhole
commented
7 months ago Submitted this version for review
Hi @Anarios I made 2 separate PRs, one for the Userscript (this one, #1046) and one for browser extensions (#1045) and I think you merged the wrong PR for the extension update 😁 (I tested your release and my changes doesn't appear in the popup.js file)
Sorry I should have specified it at the beginning of these 2 PRs
~Could you please format it with prettier, so that there are less formatting changes, and only the actual code changes in PR?
Yeah the precommit hooks already took care of this. And the huge Prettier changes surprised me, that's why I made 2 separate commits :
git commit -n) : 17f5bdf which contains only the functionnality changesBTW I did the same with the other (browser extensions) PR (#1045) so if you want me to revert the Prettier commit before merging, I can do that ;)
Another clarification: there is no version bump in my two PRs (I always leave it to the maintainer) so you'll need to bump this Userscript version :)
Anarios
commented
7 months ago Woah, yep, thanks for catching.
Anarios
commented
7 months ago theblackhole
commented
7 months ago Woah, yep, thanks for catching.
No problem :)
Add support for new UI. (See extension issue #1043)
Tested with both new and old UI (since it's in a A/B testing phase) on Windows with :
And on Linux (KUbuntu) with :
Preview of the userscript working with the new UI: