search

Anarios / return-youtube-dislike

Chrome extension to return youtube dislikes
https://returnyoutubedislike.com/
GNU General Public License v3.0
12.32k stars 544 forks source link

Extension - Fix new (spring 2024) UI buttons position #1047

Open theblackhole opened 2 months ago

theblackhole commented 2 months ago

With the new (spring 2024) UI, action buttons are aligned to the left but an obsolete patch make them align to the right instead.

This commit removes this obsolete patch in order to restore the original alignment (left for new UI and no changes/right for the previous UI).

Tested with the new and previous UI (Firefox and Edge on Windows) with and without the ratio bar

Screenshot of the issue:

What it's supposed to look like (RYD extension disabled) :

Screenshot of the provided fix:

Anarios commented 3 weeks ago

@theblackhole do you still experience the problem, is this patch still required?

I'm hesitant about removing older code - because many people can still have that version of UI.

theblackhole commented 2 weeks ago

@Anarios Unfortunately I don't have the new (spring 2024) UI anymore (I don't know why) so I can't tell if the patch is still required. But the current UI (before this big layout change) isn't affected by this patch, I think this was for an even older version of the UI

theblackhole commented 1 week ago

@leakedmemory In your screenshot, return-youtube-dislike doesn't work at all 😅

leakedmemory commented 1 week ago

@theblackhole Indeed, that was when I thought the bug of #1037 was not interfering with this, but I'm wrong. This still happens and that other bug too, so I'm gonna remove my other comment. Thanks.