Anarios / return-youtube-dislike

Chrome extension to return youtube dislikes
https://returnyoutubedislike.com/
GNU General Public License v3.0
12.65k stars 566 forks source link

(Bug): Shows previous video's dislike count if current video's count is not in the db #498

Open sy-b opened 2 years ago

sy-b commented 2 years ago

Video link where you see the problem


What happened?

https://user-images.githubusercontent.com/94835959/156537542-2af91d1d-40b1-4487-bbab-0b0c4bf0455b.mp4


How to reproduce/recreate?

  1. Find a video that is not in the RYD database. It should show like count and Dislike instead of the dislike count (not Dislike Disabled).
  2. Load that video (e.g. 17Etzak2IfM)
  3. Click on any other videos from the same page.
  4. Go to the previous page using Alt + ← or using button or touchpad gestures.

Result:

cyrildtm commented 2 years ago

Seems like the async request variable is not flushed properly

https://github.com/Anarios/return-youtube-dislike/blob/9f257b354c2a933610fafc7c466af0572eef91bf/Extensions/combined/src/state.js#L96 https://github.com/Anarios/return-youtube-dislike/blob/9f257b354c2a933610fafc7c466af0572eef91bf/Extensions/combined/src/state.js#L114

Both lines create variables within the function's scope, which is weird. Bug?

RYD server return from console log: Step 1: 404 Step 2: actual count Step 3: 404

sy-b commented 2 years ago

In my case that 404 is related to https://github.com/Anarios/return-youtube-dislike/issues/497