(Bug): The "accessible" color scheme is not accessible for people with Tritanopia

[MilesBHuff]

Hey! So, your "accessible" color scheme, while definitely accessible for people with protanopia and deuteranopia, is actually not accessible for people with tritanopia. Thankfully, people with tritanopia can actually see the default colorscheme just fine. However, I wanted to let you know that there is one colorscheme that supports all three kinds of human dichromats: magenta vs green. The reason why, is that magenta is obligatorily composed of equal parts red and blue -- there is no magenta wavelength of light; it's purely a fiction of the human brain. Protanopes see magenta as blue, and green as yellow; deuteranopes also see magenta as blue, and green as yellow (This is because primates duplicated their long cone, and protanopes and deuteranopes are missing just one copy of this cone.); and (lastly) tritanopes see magenta as red, and green as blue. Magenta-green is the ONLY two-hue scheme that has this ability.

For maximum accessibility with as few presets as possible, I would suggest the following:

• Conventional (red/green) (for trichromats)
• Colorblind (magenta/green) (for dichromats)
• High Contrast (black/white) (for monochromats and people with severe vision impairments)
• Custom

(Using magenta/green makes the "Neon" magenta/cyan colorscheme mostly redundant, so it can be removed.)

[cyrildtm]

Hi @MilesBHuff @sy-b @PickleNik I just pushed a new color themes "Watermelon" "Hibiscus" "Capetian" and "Custom". Do you want to take a look? Do you know how to build the extension? Would you go to my branch https://github.com/cyrildtm/return-youtube-dislike/tree/ColorizedButtonsAndBar-New and see if it's right?

[sy-b]

nice 👍

For custom, there should some visual cue to conveying - "hey 👋, you can click here to open a color palette"

[cyrildtm]

hey 👋

For now, there's a little pixel bump after selecting "custom", because I was lazy 😮 So it looks like that's not enough? What about

👉

[sy-b]

I meant - you should add some visual cue - some UI thing - which can convey that message Right now, the clickable & non-clickable colors look the same.

You can make it look more like a button.

• Round corners
• Shadows; you'll probably have to add a light colored rectangle behind the buttons.
• Come up with a better idea (preferred)

refer: https://health.gov/healthliteracyonline/organize/section-4-5/

[cyrildtm]

Trust me I tried rounded corners way before I implemented colors. It doesn't look good on black

I don't want to put too much words as (1) It's annoying and diluting and (2) it breaks the line and looks very ugly, compromising the purpose of visual cues.

Using a 3D shape is just too weird in modern days. Using shadows has the exact problem as you said; as a consequence requiring extra space which will, again, breaks the line.

For my own defense, if a user wants to use custom colors, they will have to switch from a predefined scheme, which shows the four color blocks on the right. By that time, they should have figured out how to interact with this option.

I'm open to better ideas. Otherwise, I can just put the swatches in a new line, and in the drop-down, write

Custom (click) 👇

[PickleNik]

the input field styling will be edited in the future anyways, so as long as the new color themes are in, it's gtg in my opinion

[cyrildtm]

@PickleNik Is there any open discussion on this?

[PickleNik]

@PickleNik Is there any open discussion on this?

I think I sent examples of what I'm working on above

[cyrildtm]

@PickleNik Is there any open discussion on this?

I think I sent examples of what I'm working on above

Oh come on that's not very friendly. Do you think you can send a full example so others can get some idea how far we need to go with this, and how much time we don't have to waste any more? It's a open source project anyway. Why being so defensive?

BTW Your examples only had dark theme, and people are already complaining the colors being off tune on white. Assume 10% of this extension's user base wants to use colors if they are easier to see.

Besides, Your examples only had four buttons, you may probably consider putting more visual cues, so people know the thumbs are interactive inputs.

[PickleNik]

@cyrildtm sorry I didn't have the time to make a PR for it yet. What I meant is that I would rather the already made color schemes were added and merged so that I can rebase on top of it and resolve any conflicts. I'm not saying my additions are perfect, if you would like to work on more improvements - please do, I will resolve any conflicts that may arise on my side. The screenshots I sent above pretty much sum up the changes I've made for settings minimization, it's not final, I know the colorpicker thumbs aren't exactly intuitive.

[PickleNik]

By gtg I meant good to go as in good to merge, if there was any confusion 😅

[sy-b]

👍

[cyrildtm]

@PickleNik Alright man. Just waiting for your PR then.

[PickleNik]

@PickleNik Alright man. Just waiting for your PR then.

I was saying it would be better to merge this first, but you can wait if you want, it's up to you :)

[cyrildtm]

Yeah my PR is ready for merge as of now. Improving the GUI will be another project. Thanks!

[cyrildtm]

As for the thumbs, there is definitely a free version on fonts.google.com, though the outline is bulkier, but I could tweak some raw svg values to avoid any copyright issues

see https://github.com/Anarios/return-youtube-dislike/issues/656