Closed sp96296 closed 2 years ago
Yeah, I can confirm this is happening for me too. It has been since the 3.0.0.1 3.0 update released.
Browser: Brave (Chromium Based) Browser version: Version 1.39.84 Chromium: 101.0.4951.41 (Official Build) beta (64-bit) Extension or Userscript: Extension Extension version: 3.0.0.1
I've noticed it only seems to re-open after first turning on my computer for the day. Closing/reopening the browser (or restarting PC) doesn't seem to make it appear once it already has for the day. Not sure what the connection is, maybe a session token/cookie expiring? I don't know the codebase so this is just a guess.
Very strange, 3.0.0.1 was supposed to fix it. Are you sure that it happened after extension was updated to 3.0.0.1, not before?
Ah, it would have been 3.0 that it started then, however it has still opened the page since 3.0.0.1 has released. It might be that the extension hasn't updated to 3.0.0.1 until very recently, so I'll keep an eye on it and see if it continues.
Thanks! Yes, that's my guess as well - I hope that it shouldn't happen in 3.0.0.1 anymore.
Very strange, 3.0.0.1 was supposed to fix it. Are you sure that it happened after extension was updated to 3.0.0.1, not before?
It still seems to be happening to me, just happened now actually
Can you try removing the extension from your account and re-installing? It should pop up once more, but that should be it. Your storage variables may be messed up
Can you try removing the extension from your account and re-installing? It should pop up once more, but that should be it. Your storage variables may be messed up
Just tried that, and it seems to have worked. I did not experience it aside from the initial update page post-installation, even after device reboot. I think I will close this bug/issue, but maybe this could be added to the FAQ in case other's also come across this?
Yes it's actually in the "Help" page. Sometimes things just don't work as expected, and the old "turning it off and on again" trick may be the solution
The page opened again
@Anarios should we remove this popup altogether? It has little benefit but creating too much pain. Why do we need to keep reminding users we have updates? I hate updates.
@sy-b any ideas why the current implementation is still this buggy?
@sp96296 A couple of questions to you: Does your Chrome update often? (Is it Canary?) Besides, do you have a good and constant Internet connection?
@sp96296 A couple of questions to you: Does your Chrome update often? (Is it Canary?) Besides, do you have a good and constant Internet connection?
It's canary, and internet is constant
It's canary
Why is the storage bugging ?!? Is it normal for canary?
@sy-b any ideas why the current implementation is still this buggy?
Let's try chrome.storage.
local
. Maybe there's something fishy with sync
.
from: Why isn't localStorage persisting in Chrome?
Summary seems to be that that you must attempt a read of the key in order to persist it.
Issue 160056: Storage doesn't persisnt if you don't try to read the value.
related?
Not surprised to see Chrome is this broken.
@sy-b Let's use BOTH sync and local storage. Reasons:
pseudo-pseudo-code: Add listener: update event? (I can't emphasize this too much) If update event is browser update, exit. Read sync storage: show updates? last popup version? If show updates is false or last popup is the same as current, exit. If show updates is undefined or last popup is undefined, Read local storage: show updates? last popup version? If local show updates is false or local last popup is the same as current, write these values to sync variables. Read them immediately. Exit. If local show updates is undefined or last popup is undefined, force write both sync and local variables: show updates = false, last popup version = current. Read them immediately. Do not show popup window. Exit. Show popup window. Write both sync and local last popup version to current. Read them immediately. Exit.
Will make a diagram as soon as I get some free time.
Me: Look Mom! No hands! Mom: Laugh as you can now, until you fall and break your teeth, which you will.
👍
as soon as I get some free time.
Yeah, kinda same here. Still trying to find it.
Me: Look Mom! No hands! Mom: Laugh as you can now, until you fall and break your teeth, which you will.
My sense of humor isn't wasn't so bad in general but I don't understand how is this related & if it was meant to be humorous in the first place.
Don't assume things will still work if you take the easy way. It may seem to but given time it will break. Just take the right/safe way.
3.0.0.2 is out, please close the issue if it's fixed with this update. Or comment if it still repeats.
Browser
Google Chrome
Browser Version
103.0.5033.0
Extension or Userscript?
Extension
Extension/Userscript Version
3.0.0.1
Video link where you see the problem
N/A
What happened?
Oftentimes after opening the browser, the update page is opened as a new tab. I think this has been going on since 3.0.0.0 launched, but not sure. Included below is the update page in question, the URL is the chrome-extension:// URL.
How to reproduce/recreate?