Number of dislikes is shown on the "Share" icon

Anarios / return-youtube-dislike

Chrome extension to return youtube dislikes

https://returnyoutubedislike.com/

GNU General Public License v3.0

12.69k stars 568 forks source link

Number of dislikes is shown on the "Share" icon #948

Closed Tasosgemah closed 1 year ago

Tasosgemah commented 1 year ago

Have you tried to find similar open issues?

[X] Yes, this issue is not a duplicate

Browser

Firefox

Browser Version

110.0.1

Extension or Userscript?

Extension

Extension/Userscript Version

3.0.0.10

Video link where you see the problem

https://www.youtube.com/watch?v=kpGo2_d3oYE

What happened?

The number of dislikes is shown on the "Share" icon.\

Dislike icon doesn't have any number but you can still see it on the ratio bar pop-up. And it's always the same number as the one shown on the "shares" icon.

The video linked is an example of many dislikes and how it's the same number as the share number.

How to reproduce/recreate?

Watch any video.

Will you be available for follow-up questions to help developers diagnose & fix the issue?

Yes

Nightcaat commented 1 year ago

Hi, is this still happening for you?

alpe12 commented 1 year ago

Hi, is this still happening for you?

Don't know about OP. But for me, yes. :/ 3.1.2 userscript on firefox.

Tasosgemah commented 1 year ago

Hi, is this still happening for you?

Yes.

Enrico9431 commented 1 year ago

Has been for me as well for quite a while now on chrome

Bravo555 commented 1 year ago

Same issue in Firefox 119.0 on Windows 11 with RYD v3.0.0.12.

Looks like the share button is erroneously returned on this line:

https://github.com/Anarios/return-youtube-dislike/blob/2c7dd8d8caef8c584002d49c3013ea9d8d079453/Extensions/combined/src/buttons.js#L54

or on line 787 when viewed in a debugger:

Bravo555 commented 1 year ago

I created a fix, If you want to test it, you can download the extension for your browser from here: https://github.com/Bravo555/return-youtube-dislike/releases/tag/v3.0.0.13r1.

You'll need to sideload the extension into the browser.

Alternatively, if you don't want to load unverified zip files, you can clone my branch with the fix and build it yourself by following the CONTRIBUTING.md guide.