Anarios / return-youtube-dislike

Chrome extension to return youtube dislikes
https://returnyoutubedislike.com/
GNU General Public License v3.0
12.55k stars 561 forks source link

Dislikes does not work If you are logged into an account #965

Closed GladistonXD closed 10 months ago

GladistonXD commented 11 months ago

Have you tried to find similar open issues?

Browser

Chrome

Browser Version

118.0.5993.88

Extension or Userscript?

Extension

Extension/Userscript Version

3.0.0.11

Video link where you see the problem

All links

What happened?

When I log out the count appears, as soon as I log in to any account it disappears again

How to reproduce/recreate?

When I log out the count appears, as soon as I log in to any account it disappears again

Will you be available for follow-up questions to help developers diagnose & fix the issue?

Yes

Senbonzakura1234 commented 11 months ago

@GladistonXD currently mine isn't working in any case at all, tried incognito tab and no difference. image

michalrozek90 commented 11 months ago

I can confirm that it's not working only when you are logged in. After log out I was able to see dislikes but only then.

VadimSaveljev commented 11 months ago

It does work if you are not logged in @Senbonzakura1234 Try enabling extension in incognito mode, I think you forgot that judging by the screenshot

update: I tried logging off not in incognito window and it didn't work, works only in incognito

Senbonzakura1234 commented 11 months ago

It does work if you are not logged in @Senbonzakura1234 Try enabling extension in incognito mode, I think you forgot that judging by the screenshot

Is there any info out there indicate that youtube is disabling the dislike count api output? @SaltyCucumber I only notice the dislike count problem all because of the new anti adblock policies

VadimSaveljev commented 11 months ago

Is there any info out there indicate that youtube is disabling the dislike count api output? @SaltyCucumber I only notice the dislike count problem all because of the new anti adblock policies

@Senbonzakura1234 I think the API works fine, it's some other issue, cause you can open console (F12) and see the dislike counter there: [return youtube dislike]: SET dislikes 571

so it does get the data itself, it's just an UI issue it seems Uncaught (in promise) TypeError: Cannot read properties of null (reading 'parentNode') this line indicates that they probably changed some HTML/CSS and the extension code can't parse it properly

Senbonzakura1234 commented 11 months ago

Is there any info out there indicate that youtube is disabling the dislike count api output? @SaltyCucumber I only notice the dislike count problem all because of the new anti adblock policies

@Senbonzakura1234 I think the API works fine, it's some other issue, cause you can open console (F12) and see the dislike counter there: [return youtube dislike]: SET dislikes 571

so it does get the data itself, it's just an UI issue it seems

Thank god, i though youtube bold enough to scrubed this data off for good.

Senbonzakura1234 commented 11 months ago

Is there any info out there indicate that youtube is disabling the dislike count api output? @SaltyCucumber I only notice the dislike count problem all because of the new anti adblock policies

@Senbonzakura1234 I think the API works fine, it's some other issue, cause you can open console (F12) and see the dislike counter there: [return youtube dislike]: SET dislikes 571

so it does get the data itself, it's just an UI issue it seems Uncaught (in promise) TypeError: Cannot read properties of null (reading 'parentNode') this line indicates that they probably changed some HTML/CSS and the extension code can't parse it properly

Anyway this show youtube could change the ui frequently and it will disfunction our extension, we should create our own like and dislike bar, or showing them in the extension popup, things we can control, like what they doing with ghostery. @SaltyCucumber

VadimSaveljev commented 11 months ago

Anyway this show youtube could change the ui frequently and it will disfunction our extension, we should create our own like and dislike bar, or in the extension popup, like what they do with ghostery. @SaltyCucumber

It's just the most convenient way to see the ratio where it's suppose to be naturally, the problem with this approach is that sometimes it will be broken, like it is right now.

Toni500github commented 11 months ago

try to use the latest version 3.0.0.12 from here or wait until the webstore updates the extension, because it works to me now with this version

GladistonXD commented 11 months ago

Version 3.0.0.12 released today resolved this issue.

GladistonXD commented 10 months ago

The same problem came back

Toni500github commented 10 months ago

Bruh

Senbonzakura1234 commented 10 months ago

Anyway this show youtube could change the ui frequently and it will disfunction our extension, we should create our own like and dislike bar, or showing them in the extension popup, things we can control, like what they doing with ghostery. @SaltyCucumber

@GladistonXD again i think we should have fallback popup detached from the youtube UI that user can check themselves in case youtube change the UI again. Since youtube even try slowing down none-chrome browsers in an attempt stopping ad blockers, there is a possibility that they now also targeting us by frequently changing the UI

GladistonXD commented 10 months ago

Yes, apparently YouTube changes its buttons for testing on some users, this time it was changing the buttons from "segmented-dislike-button" to "dislike-button-view-model" I had made a crude change, but much easier to resolve if it changes again, I will try to automate this with regex later to resolve it once and for all:

function getDislikeButton() {
  return document.querySelector("#segmented-dislike-button, #dislike-button, dislike-button-view-model");
}

function getLikeButton() {
  return document.querySelector("#segmented-like-button, #like-button, like-button-view-model");
}