Anastasia-Labs / lucid-evolution

https://anastasia-labs.github.io/lucid-evolution/
39 stars 14 forks source link

Adding support for multisig wallet API (CIP-106) #139

Open leo42 opened 3 months ago

leo42 commented 3 months ago

WARNING: Untested, this is not yet ready to merge!

I have created the initial layout for this feat, I am opening a pull request to get feedback on the last part I need to complete before staring with testing.

to submit a transaction the developers building against CIP-106 need to attach the script, and the correct Key Hashes as "extra signers"

To do this I have 2 options in mind : A) create a getRefTransaction() , that will return a tx complete with all the requirements that the dev can then expand on or compose with all the other tx they want to perform.

B) During tx.complete() add a check if the Wallet is of type MultisigApi and attach all the required parameters before finalizing.

B seems to be the path with the least amount of friction as devs would be able to use it almost exactly how they would a regular wallet.

changeset-bot[bot] commented 3 months ago

⚠️ No Changeset found

Latest commit: 1ee281e69c19426c988d79bc1772e77d679d63a7

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR