search

AnatomicMaps / flatmap-maker

Make anatomical flatmaps from SVG diagrams, Powerpoint slides, and other sources.
Apache License 2.0
2 stars 6 forks source link

Possibility to get empty candidate when try to connect two consecutive centrelines without common feature. #91

Closed napakalas closed 2 weeks ago

napakalas commented 2 weeks ago

This two lines call min(candidates, key=candidates.get)

https://github.com/AnatomicMaps/flatmap-maker/blob/2d8f7f588b66eef8dc4e92b55c44ecfcae87db0d/mapmaker/routing/__init__.py#L1042 https://github.com/AnatomicMaps/flatmap-maker/blob/2d8f7f588b66eef8dc4e92b55c44ecfcae87db0d/mapmaker/routing/__init__.py#L1078

There is a possibility of grace error when there is no candidates, hence should improve by conditionals.