AnatomicMaps / flatmap-maker

Make anatomical flatmaps from SVG diagrams, Powerpoint slides, and other sources.
Apache License 2.0
3 stars 7 forks source link

Need to update the mechanism to identified centrelines that connected centrelines nodes. #97

Open napakalas opened 1 month ago

napakalas commented 1 month ago

In most case, https://github.com/AnatomicMaps/flatmap-maker/blob/ad61b92445a3a6922f487fb5cbd78cb078b52a50/mapmaker/routing/__init__.py#L1093-L1104 is effective in identifying and adding needed centrelines. However, in some cases, such as bromo-1, it adds unnecessary centrelines.

As shown in this image, there unnecessary added centrelines are across sympathetic chain. Screenshot 2024-10-15 at 10 09 12 AM

dbrnz commented 1 month ago

The attached screen shot doesn't indicate the centrelines -- please use the Show centrelines? option of the NERVES control in the viewer to add an image with centrelines.

napakalas commented 1 month ago

Here is the screen shot with the centrelines indication. Note that the unnecessary centrelines are those with blue cross. Screenshot 2024-10-15 at 11 16 57 AM

dbrnz commented 1 month ago

What general role do those centrelines with the blue cross play? Are they needed for some particular neuron paths? What happens if they are removed??

Someone (Naz?) added them, but why only T1-T2-T3-T4-T5-T6 and T12-T13-L1 (this last two don't have associated paths) and not for the intervening segments?

A simple test would be to remove them (all that's needed is to take them out of the networks block of properties.json; there's no need to edit the SVG) and see what happens.

napakalas commented 1 month ago

I will check it as suggested and see if any other paths are affected or not if this centreline are removed from properties.json.

napakalas commented 1 month ago

I confirm that removing centrelines S46_T1 - S46_T2 - S46_T3 - S46_T4 - S46_T5 - S46_T6 in flatmap source solves this issue.

dbrnz commented 1 month ago

For consistency, shouldn't the T12-T13-L1 ones also be removed?

napakalas commented 1 month ago

I have checked and removed them. I also removed the other similar centrelines up to S2.