search

AnatomicMaps / flatmap-viewer

Apache License 2.0
0 stars 7 forks source link

Visualisation issue with setVisibilityFilter and clearVisibilityFilter #28

Open alan-wu opened 6 months ago

alan-wu commented 6 months ago

There are currently some visualisation issues when calling setVisibilityFilter and clearVisibilityFilter methods with flatmap-viewer 2.8.0.

  1. All path ways appears to be thicker after the first call to setVisibilityFIlter
  2. Large grey area on FC map after calling the setVisibilityFilter and clearVisibilityFilter
dbrnz commented 6 months ago

Would you please add a screenshot showing the grey area -- thanks!

alan-wu commented 6 months ago

@dbrnz Here you go:

image

Link to the FC map: https://mapcore-demo.org/current/sparc-app-2/maps/?type=fc

dbrnz commented 6 months ago

There are a few different issues at play here:

  1. A few blocks in the FC source Powerpoint have been drawn as thick lines.
  2. A bug in mapmaker whereby lines that aren't identified as vasculature (i.e. these thick lines) don't have their width scaled from PPTX units to map units.
  3. The viewer requires more work done to merge it's different filters.

The mapmaker bug though is the main culprit. This has been resolved (commit df86318) and the curation map server now has the fixed FC map.

Item 3 means the blocks from 1 above now show as below (they should be green like the horizontal block). This will be resolved with ongoing work on the FC map and the viewer.

Screenshot 2024-05-15 at 8 23 58 PM
alan-wu commented 6 months ago

@dbrnz Thanks for looking into it and its great that you are looking into No 3. I notice the filter is working with enablePath and enableCentrelines but it is not working with enableConnectivityByTaxonIds.

dbrnz commented 6 months ago

I notice the filter is working with enablePath and enableCentrelines but it is not working with enableConnectivityByTaxonIds.

What version of the viewer are you using? enableConnectivityByTaxonIds simply works for me.