search

AnatomicMaps / functional-connectivity

0 stars 3 forks source link

Parts of INTEGUMENTARY SYSTEM are line shapes, not rectangular blocks #1

Closed dbrnz closed 1 year ago

dbrnz commented 1 year ago

In particular some of its vertical components.

They need to be redrawn as rectangles and then all components of the integumentary system to be grouped together as one.

dbrnz commented 1 year ago

These show up in mapmaker's log as:

2023-03-17 18:59:38,507 WARNING: Connection has unconnected end(s): FC(organ-blocks/slide-01/18: line/CD_CLASS.CONNECTION/FC_CLASS.UNKNOWN/FC_KIND.UNKNOWN/ ``)
2023-03-17 18:59:38,507 WARNING: Connection has unconnected end(s): FC(organ-blocks/slide-01/19: line/CD_CLASS.CONNECTION/FC_CLASS.UNKNOWN/FC_KIND.UNKNOWN/ ``)
2023-03-17 18:59:38,507 WARNING: Connection has unconnected end(s): FC(organ-blocks/slide-01/20: line/CD_CLASS.CONNECTION/FC_CLASS.UNKNOWN/FC_KIND.UNKNOWN/ ``)
2023-03-17 18:59:38,507 WARNING: Connection has unconnected end(s): FC(organ-blocks/slide-01/21: line/CD_CLASS.CONNECTION/FC_CLASS.UNKNOWN/FC_KIND.UNKNOWN/ ``)
2023-03-17 18:59:38,508 WARNING: Connection has unconnected end(s): FC(organ-blocks/slide-01/22: line/CD_CLASS.CONNECTION/FC_CLASS.UNKNOWN/FC_KIND.UNKNOWN/ ``)

for every Powerpoint slide (= map layer).

keeran97 commented 1 year ago

Im not seeing this in my log or able to find the components organ-blocks/slide-01/18 to slide-01/22. confirming this has been resolved?

keeran97 commented 1 year ago

With a little tweaking to the logging I can see the errors relating to organ-blocks/slide-01/18 to 22 in my log now. But i am having trouble identifying the IDs in the ppt file. I am using the flatmap viewer and tooltip to search and ID them but cant find the ones mentioned in the log (I can raise a separate issue for this)

dbrnz commented 1 year ago

At some point these features will be highlighted in the viewer (e.g. coloured yellow), however at the moment you will have to rely on a visual comparison between the source Powerpoints and the generated map.

What blocks make up the integumentary system on each of the Powerpoints? Which blocks are rectangles? Which are lines? How have they been grouped?

keeran97 commented 1 year ago

this has been resolved in commit c3aa27f of the keerans-changes branch