Unknown blue block in digestive system

[keeran97]

There is a blue block in the ppt files in the digestive system that is causing errors below (in each ppt file). Speaking to Naz, she mentioned it is intended for the enteric system but there is no label. I can add the label (shown in screenshots) but just want to confirm whether it is correct or we remove the block?

2023-03-22 13:56:24,615 ERROR: FC type unknown: FC_CLASS.UNKNOWN( in None)
2023-03-22 13:56:24,618 ERROR: FC type unknown: FC_CLASS.UNKNOWN( in FC_CLASS.SYSTEM(DIGESTIVE SYSTEM in FC_CLASS.LAYER(Organ-blocks Layer in None)))
2023-03-22 13:56:24,618 ERROR: FC type unknown: FC_CLASS.UNKNOWN( in FC_CLASS.UNKNOWN( in FC_CLASS.SYSTEM(DIGESTIVE SYSTEM in FC_CLASS.LAYER(Organ-blocks Layer in None))))
2023-03-22 13:56:24,618 ERROR: FC type unknown: FC_CLASS.UNKNOWN( in FC_CLASS.UNKNOWN( in FC_CLASS.SYSTEM(DIGESTIVE SYSTEM in FC_CLASS.LAYER(Organ-blocks Layer in None))))

[dbrnz]

To me this is work-in-progress -- not all errors reported by mapmaker necessarily need resolving, and maybe these fall into that category.

Rather than simply removing things from Powerpoint, would it not be better to understand how the enteric system is intended to be represented on the FC map?

[nickerso]

In the push to an initial release, all work-in-progress should be dropped - particularly if it will help move things forward.

Having said that, however, I'd guess the enteric system is quite relevant for SPARC and I'd be surprised if its not in there to some extent. Perhaps in this case, @NEbrahimi can look at what is needed to move the enteric system out of a work-in-progress state and whether it will be ready for the initial FC release.

[keeran97]

@dbrnz The last screenshot is from the mapviewer (attached again below). The block is hidden behind the FTUs of the digestive system and the tooltip shows the Error and ID. Im not sure of the progress of the map and also not sure of the sources therefore unsure how to proceed. Raising this issue was to flag it and discuss how it will be represented, if at all. I had thought we could resolve the error for now while it is a WIP but I can ignore it for now.

[NEbrahimi]

Even though we haven't added the connectivity information for the enteric system yet, I suggest keeping the blue block and labeling it as the enteric system. Would that work?

[keeran97]

I have played around trying that (so far unsuccessfully) but that's what I suggest too if we're not completing it at the moment.

[keeran97]

Noting here that this class of errors has increased with the addition of green rectangles of the integumentary system (from Issue 1). These blocks have been appropriately grouped. I suspect the error is due to the blocks not containing any FTUs or other such information. I have tried using text boxes with names instead, but this doesn't work either. I am unsure how to resolve or add the FC type. The below is the errors extracted from just the organ blocks ppt. The other ppts files have these errors too.

Is this an issue relating to the set up in power point? If so how is it resolved (if grouping or naming doesn't work)? or is it ignoreable for now?

2023-03-31 13:56:26,500 INFO: Slide 1, organ-blocks
2023-03-31 13:56:40,237 ERROR: FC type unknown: Shape organ-blocks/slide-01/2504: {'shape-name': 'Rectangle 2503', 'shape-kind': 'rect', 'cd-class': 'celldl:Component', 'name': ''}
2023-03-31 13:56:40,238 ERROR: FC type unknown: Shape organ-blocks/slide-01/2505: {'shape-name': 'Rectangle 2504', 'shape-kind': 'rect', 'cd-class': 'celldl:Component', 'name': ''}
2023-03-31 13:56:40,238 ERROR: FC type unknown: Shape organ-blocks/slide-01/2506: {'shape-name': 'Rectangle 2505', 'shape-kind': 'rect', 'cd-class': 'celldl:Component', 'name': ''}
2023-03-31 13:56:40,244 ERROR: FC type unknown: Shape organ-blocks/slide-01/7124: {'shape-name': 'Rectangle 7123', 'shape-kind': 'rect', 'cd-class': 'celldl:Component', 'name': ''}
2023-03-31 13:56:40,244 ERROR: FC type unknown: Shape organ-blocks/slide-01/7191: {'shape-name': 'Rectangle 7190', 'shape-kind': 'rect', 'cd-class': 'celldl:Component', 'name': ''}
2023-03-31 13:56:40,244 ERROR: FC type unknown: Shape organ-blocks/slide-01/7753: {'shape-name': 'Rectangle 7752', 'shape-kind': 'rect', 'cd-class': 'celldl:Component', 'name': ''}
2023-03-31 13:56:40,244 ERROR: FC type unknown: Shape organ-blocks/slide-01/7756: {'shape-name': 'Rectangle 7755', 'shape-kind': 'rect', 'cd-class': 'celldl:Component', 'name': ''}
2023-03-31 13:56:40,244 ERROR: FC type unknown: Shape organ-blocks/slide-01/7758: {'shape-name': 'Rectangle 7757', 'shape-kind': 'rect', 'cd-class': 'celldl:Component', 'name': ''}
2023-03-31 13:56:40,244 ERROR: FC type unknown: Shape organ-blocks/slide-01/17: {'shape-name': 'Rectangle 16', 'shape-kind': 'rect', 'cd-class': 'celldl:Component', 'name': ''}

[dbrnz]

Resolving the issue with grouping of the integumentary system has required changes to mapmaker since some of the the rectangles making up the group are disjoint. Nonetheless, underlying this is the fact that the rectangles are not all the same shade of green -- in this instance, mapmaker's colour matching test has been relaxed, but in general, blocks must have the same colour to be considered as part of a single group.

[keeran97]

@dbrnz i have gone through and made sure the blocks on the integumentary system are of the same shade. latest files are at the head of the keerans-changes branch.

[dbrnz]

The next set of errors are:

2023-04-18 11:33:53,022 ERROR: FC type unknown: Shape organ-blocks/slide-01/2504: {'shape-name': 'Rectangle 2503', 'shape-kind': 'rect', 'cd-class': 'celldl:Component', 'name': ''}
2023-04-18 11:33:53,022 ERROR: FC type unknown: Shape organ-blocks/slide-01/2506: {'shape-name': 'Rectangle 2505', 'shape-kind': 'rect', 'cd-class': 'celldl:Component', 'name': ''}
2023-04-18 11:33:53,022 ERROR: FC type unknown: Shape organ-blocks/slide-01/2505: {'shape-name': 'Rectangle 2504', 'shape-kind': 'rect', 'cd-class': 'celldl:Component', 'name': ''}

and relate to the enteric system being shown (by three light blue rectangles) but not identifiable. 1) Why three overlapping rectangles? Would one be sufficient? 2) The largest rectangle needs to be labelled ENTERIC SYSTEM, with the other two (if required) grouped together with it.

[keeran97]

@dbrnz im not sure why 3 overlapping triangles were made. ill have to bring that up with Peter and see. But the 3 rectangles were already grouped and labelled. I've just gone through and labelled the largest one with enteric system

[keeran97]

@dbrnz this is what Peter had to say.

Just remembered that I did it that way because there are two layers to the enteric system - submucosal and myenteric. The block in the middle was just to separate them.

[dbrnz]

Thanks -- we'll leave things are they are with multiple blocks.

[dbrnz]

I've just gone through and labelled the largest one with enteric system

Sorry, the name must all be in UPPERCASE to be recognised as a system...

[keeran97]

@dbrnz ive gone through and updated them.

[dbrnz]

@keeran9, a feature's name/label feature has to be given as text content, exactly as is done for all the other features in the FC Powerpoint sources. Please look at and understand how FC features have names assigned and only then add the label ENTERIC SYSTEM to the largest rectangle of the enteric system group.

[keeran97]

@dbrnz sorry i misunderstood. updated now but bear in mind it cant be seen right now as the two light blue rectangles are blocking. thought it best to leave it like this until we add to the enteric system

[dbrnz]

That's fine -- these labels are just for identification and don't appear on the generated map (where the label shows as a tooltip).