Wip 1

[cederlys]

Hi!

I've been playing with the software for the past few days. I now have something that is approaching usefulness for me. I thought I'd share what I have.

Fell free to include it as-is or cherrypick the parts you like (if any). If you want me to create separate merge requests for each unrelated thing I'll do so, but I might not have time to do that right away as I will be traveling the next few days.

I have a few things I'd like to improve when I have the time:

• The Home Assistant Discovery creates boring names for the sensors. I'd like to add a new field during WiFi setup where you can enter a name ("Master Bedroom") and the sensor names will be created based on that ("Master Bedroom Temperature"/"Master Bedroom Humidity"/"Master Bedroom Water Temperature").
• Home Assistant Discovery for the other supported sensors as well
• Publishing the sketch MD5 and chip ID via MQTT could be a privacy issue, and should probably be disabled by default (or if you are using the default server)

[leon-anavi]

Hi @cederlys,

Great work! I need a few days more to review and merge it!

Thanks, Leon

[cederlys]

I'm about to push two more commits to this. One that makes the Home Assistant sensor name configurable during setup, and one that saves the calibration data persistently to the flash filesystem, so that you don't need to publish an MQTT command every time the thermometer reboots.

I may find time soon to split this branch into separate merge requests for different features, if you prefer that. (I know I would, if I were maintainer of this.) Just say the word.

[leon-anavi]

Hi @cederlys,

You have done an amazing work! Thank you for the contribution.

I've verified that everything builds and boots although I didn't test the Home Assistant Discover feature. My only concern is that sharing the chip ID might be a privacy issue, for example (with dummy/fake values):

Client mosqsub|25740-leon-Thin received PUBLISH (d0, q0, r0, m0, 'workgroup/d7c196eeaa61c3bcef120fe1ee1a721b/chipid', ... (21 bytes))
{"chipid":"01b3dbf6"}

May be this should be disabled by default because we have md5 of the chip ID in the MQTT topics?

Once again thank you for the awesome improvements!

Thanks, Leon