search

AnaviTechnology / anavi-thermometer-sw

Open source Arduino sketch for the smart WiFi dev board ANAVI Thermometer
GNU General Public License v3.0
27 stars 17 forks source link

Provide RSSI as numeric #4

Closed bschwehn closed 5 years ago

bschwehn commented 5 years ago

All other values are numeric, so rssi should also be numeric to simplify handling of MQTT messages consistently.

bschwehn commented 5 years ago

I like that @cederlys added the RSSI value, but in my opinion the value should be provided as numeric, not as string with unit.

That is, this change will change the MQTT message from

{"rssi": "-76 dbM"} to {"rssi":-76)

this is consistent with the temps/humidity which are also provided numerically and therefore allows consistent handling of all the sensor messages.

Note: this may break setups for people that already rely on it being provided as a string!

leon-anavi commented 5 years ago

Thank you! Looks good to me and I have merged it.

Thanks, Leon

cederlys commented 5 years ago

For the record, I think this is a good change. I have not yet done anything with the value (except looking at it manually) but I'm thinking about importing it (along with the other sensor values) to graphite. I would probably ended up with the same conclusion.

Thanks for improving my improvement!

bschwehn commented 5 years ago

Right, makes for some pretty graphs and with a couple of them distributed around the apartment, it is actually somewhat useful when you want to evaluate options to improve WiFi connections at home :+1:

2019-05-02-224832_3840x1080_scrot