search

Anber / wyw-in-js

MIT License
229 stars 16 forks source link

Build error when I use rollup without Vite #38

Closed sdv43 closed 7 months ago

sdv43 commented 8 months ago

Hi! I have custom rollup config without Vite and I'am getting next error:

Снимок экрана 2024-01-22 в 10 01 37

I created the demo repository with the error.

I tried to debug the error and found out that if I don't use typescript plugin it works fine.

The error is thrown here: https://github.com/Anber/wyw-in-js/blob/f9866705fa972cf1472ddbd41e3e5c96a34e3598/packages/rollup/src/index.ts#L137 Probably, not only Vite can ask its own keys. If I change this line with something like _ownKeys the build passes

Anber commented 8 months ago

It's an outdated check needed when we split Rollup and Vite plugins. I'll remove it in the next release. Thank you!