Anber / wyw-in-js

MIT License

229 stars 16 forks source link

fix(shared): process.env is undefined on non-node runtime issue #93

Closed AsukaCHikaru closed 2 months ago

AsukaCHikaru commented 2 months ago

Motivation

92

Summary

Access process from globalThis to support non-node runtime
Add null check to process.env

Test plan

Reproduce #92 on https://github.com/AsukaCHikaru/wyw-in-js-vite-env-issue
Execute npm run build on this PR
Copy packages/shared/lib/findPackageJSON.js to node_modules/.deno/@wyw-in-js+shared@0.5.3/node_modules/@wyw-in-js/shared/lib/findPackageJSON.js
Execute deno task dev and access localhost:5173

changeset-bot[bot] commented 2 months ago

⚠️ No Changeset found

Latest commit: ae8efb223d4e20cf6c2b8329355fabf60ed3e8ef

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR