search

AnchyDev / BreakingNewsOverride

An Azeroth Core module to allow the display of the Breaking News section on the character select screen.
MIT License
16 stars 26 forks source link

Error on Client Launch #10

Closed spiffynacho closed 7 months ago

spiffynacho commented 8 months ago

Upon patching AzerothCore with the latest updates, I am seeing this error:

image The Breaking News panel does not appear, only this error. The game functions fine once OK is clicked. I can disable the mod and the error disappears.

AnchyDev commented 8 months ago

It's possible the entire payload was not transmitted or your breaking news html is not valid. Can you share your breaking news html?

spiffynacho commented 8 months ago

It's possible the entire payload was not transmitted or your breaking news html is not valid. Can you share your breaking news html?

Here's the contents of the index.html file I was using:

<html><body>
<img src="wow.jpg" width="32" height="32" align="center"/><br/>
<h2>Vote For Us!</h2>
<p>Please vote for our server at <a href="https://topg.org/wow-private-servers/server-659002">TOPG.ORG</a>.  You can vote daily and it helps boost our ranking on their list of servers.</p><br/>
<h2>First Level 80!</h2>
<p>Congrats to Shade, the server's first level 80 character!</p><br/>
<h2>Discord Server</h2>
<p>Join our Discord server by <a href="https://discord.gg/6VbAewZV">clicking here</a>.</p><br/>
<h2>Weekly Maintenance</h2>
<p>The scheduled maintenance window is Sunday mornings from approximately 4:00-7:00 AM CST.</p>
</body></html>

It was working fine prior to the latest AC patches.

AnchyDev commented 8 months ago

At first glance that looks fine, I'm unsure of the problem and I don't see any recent commits to AC that should affect how the payload manager works.

AnchyDev commented 7 months ago

Just to update everybody, I don't know how I missed it but this is not valid HTML for this module. All single quotes should be escaped to perform correctly.

This is the HTML fixed:

<html><body>
<img src="wow.jpg" width="32" height="32" align="center"/><br/>
<h2>Vote For Us!</h2>
<p>Please vote for our server at <a href="https://topg.org/wow-private-servers/server-659002">TOPG.ORG</a>.  You can vote daily and it helps boost our ranking on their list of servers.</p><br/>
<h2>First Level 80!</h2>
<p>Congrats to Shade, the server\'s first level 80 character!</p><br/>
<h2>Discord Server</h2>
<p>Join our Discord server by <a href="https://discord.gg/6VbAewZV">clicking here</a>.</p><br/>
<h2>Weekly Maintenance</h2>
<p>The scheduled maintenance window is Sunday mornings from approximately 4:00-7:00 AM CST.</p>
</body></html>