Ancurio / mkxp

Free Software implementation of the Ruby Game Scripting System (RGSS)
GNU General Public License v2.0
512 stars 130 forks source link

Error reading Game.ini due to case sensitive parsing. #187

Closed emmauss closed 3 years ago

emmauss commented 6 years ago

MKXP cant read game.ini files which have variables in lower cases. This is different from how rpgmaker reads the ini files. RPGmaker is case insensitive when reading inis, while mkxp is sensitive. This gives an error saying that games scripts not found when using mkxp, while the game.exe runs normally.

hanetzer commented 6 years ago

https://github.com/Ancurio/mkxp/blob/master/mkxp.conf.sample#L216 @emmauss should be helpful, maybe?

emmauss commented 6 years ago

@hanetzer it is supposed to be enabled by default, there should be no need to force it.

hanetzer commented 6 years ago

@elizagamedev ah, fair enough. This may be an actual error, then, at least as far as a 1:1 rgss compat goes.

Ancurio commented 6 years ago

If someone knows how to tell boost::program_options to do the ini parsing in a case-insensitive manner, this can be implemented

hanetzer commented 6 years ago

https://stackoverflow.com/questions/15419665/boost-program-option-case-insensitive-parsing may be of use, I don' know the guts of boost::p_o to know that this is right or not.

Ancurio commented 6 years ago

Thanks for googling, but that seems to be only applicable to command line parameters (I already tried). Also searched the tutorial but to no avail. I kinda don't wanna have to hand-write a config parser just for this..

carstene1ns commented 6 years ago

TBH I have also thought about dropping boost completely. Question is, if mkxp wants to target C++11 or still stay compatible with older standards.

hanetzer commented 6 years ago

@carstene1ns honestly I'd be very happy if boost drops out of it, because its the only dep it has with dicks for build system. It would be very doable to set up a good CI server setup to deploy builds for windows and osx much more easily.

Ancurio commented 6 years ago

@carstene1ns Dropping the boost hash and set classes works, but what do you want to do about program_options? Handroll your own?

lacc97 commented 5 years ago

@Ancurio I wrote an ini parser that does not use Boost. It is PR https://github.com/Ancurio/mkxp/pull/207.

Ancurio commented 3 years ago

Should be fixed now via #207.