Ancurio / mkxp

Free Software implementation of the Ruby Game Scripting System (RGSS)
GNU General Public License v2.0
509 stars 128 forks source link

Is it possible to call `snap_to_bitmap` in RMXP? #205

Closed khiav223577 closed 3 years ago

khiav223577 commented 5 years ago

This feature seems to have beed implemented but blocked by the version check.

https://github.com/Ancurio/mkxp/blob/55f1542c767eae072f354466f27d1c5de8700a3a/binding-mri/graphics-binding.cpp#L202-L213

I tried to set rgssVersion to 2 (or 3) in mkxp.conf in order to bypass the check. It did work, but also broke many other things since my game is written in RGSS1.

Is there a way to access this method while maintaining rgssVersion in 1?

carstene1ns commented 5 years ago

Does this work in the original engine? The check could be (re-)moved then.

khiav223577 commented 5 years ago

Original RMXP engine doesn't have Graphics.snap_to_bitmap method. Not sure if removing the check is a good idea or not. Or could we reference them via custom module? For example, MKXP::Graphics.snap_to_bitmap

Ancurio commented 5 years ago

Not possible with a stock mkxp build (maybe one might hack the binary to skip the conditional jump, but that's about it).

What you're asking for is a modified mkxp that doesn't behave like the original engine. This almost always requires a custom build.