search

Ancurio / mkxp

Free Software implementation of the Ruby Game Scripting System (RGSS)
GNU General Public License v2.0
509 stars 128 forks source link

Case-insensitive ini file parser #207

Closed lacc97 closed 5 years ago

lacc97 commented 5 years ago

On Windows, RPG Maker has no issue reading Game.ini files with case insensitive key or section names (i.e. 'game' instead of the more common 'Game' section). On the other hand, MKXP fails to start with a "No game scripts specified (missing Game.ini)" error message when the section or key name is not exactly as expected.

This PR fixes this by using a case insensitive ini parser. This parser uses Boost.Optional, Boost.Algorithm and Boost.Lexical_Cast.

Only tested on Linux with CMake.

lacc97 commented 5 years ago

This would fix issue #187.

lacc97 commented 5 years ago

New commit does not use any Boost functions in the parser.

Ancurio commented 5 years ago

Hi, sorry for not responding for so long. Could you fix the indentation in iniconfig.cpp and squash all your commits into one? Thanks for working on this.

lacc97 commented 5 years ago

Hi, I'm not sure what's wrong with the indentation in the cpp file, I've tried following the code style as best I could.

lacc97 commented 5 years ago

Ok, fixed it.

Ancurio commented 5 years ago

Manually merged. Adjusted the commit message, removed x permissions from iniconfig.cpp.