Minimal modifications to unlock resollution and enable mouse support

Ancurio / mkxp

Free Software implementation of the Ruby Game Scripting System (RGSS)

GNU General Public License v2.0

509 stars 128 forks source link

Minimal modifications to unlock resollution and enable mouse support #233

Closed pk-2000 closed 2 years ago

pk-2000 commented 3 years ago

Hello Ancurio,

you may want to pull some of my modifications. The main one and the reason of my fork was to unlock the resolution of mkxp. The second was to enable mouse support, but have not found a game to test it. I tried to keep the modifications to a minimum for not breaking compatibility with mkxp.

thank you for creating mkxp

Ancurio commented 2 years ago

Hi PK, thanks for your work and sorry for the late reply. Bundling all your changes into one PR makes it hard for me to pull individual changes; it would be better if you bundled them into changesets connected by purpose. That being said, I cannot accept changes to mkxp that go beyond the RGSS specification (unless there is a specific game that makes use of Win32API calls that you want to port, then I might reconsider). For those purposes, I'd recommend checking out mkxp-z and seeing whether your changes would fit in there / making PRs to it.

pk-2000 commented 2 years ago

Thanks for responding.

I'll bundle them in 3 changesets and make a new pull request.
They are not gamespecific and do not depend/use Win32API calls. (1) the resolution change function: uses the default specs of RGSS 1,2,3, but can be overridden by editing the mkxp.conf file. (SDL API calls) (2) mouse support is added by enabling/disabling the showcursor. (SDL_Registerevents) (3) RUBY_T_RATIONAL support is needed for some rgss1 plugins.