Closed pk-2000 closed 2 years ago
How does the script query the mouse position and button state if this PR doesn't expose those values?
Sorry for being inaccurate in the above comment.
For this script to work, mkxp needs to preload your win32api wrapper https://github.com/Ancurio/mkxp/issues/73 https://pastebin.com/zXW1hdrx the script is the following https://forums.rpgmakerweb.com/index.php?threads/amaranths-super-simple-mouse-system-for-ace.17829/ https://pastebin.com/TxKQa3WK
It would be correct if you omitted the sdl queries. But, then the mouse wouldn't work with Shaz's script, even if the cursor is displayed/shown. maybe splitting the commit in two parts would be better 1st part: "Allow setting the initial value of Graphics.show_cursor from mkxp.conf" (without the 3 sdl query lines) 2nd part: "Query window size in screen coordinates" -Enables support for Shaz's Super Simple Mouse Script with Ancurio's win32api wrapper... (adding only the lines 108, 125 and 547) ps. the above sdl queries are necessary and included in the "unlocked resolution" https://github.com/Ancurio/mkxp/pull/240 ,so if you plan to adding that in the future you can ignore the 2nd part
I'm not familiar with the mkxp codebase but I can also not understand at all abot the use of the "dm" variable:
It is not even exported to ruby, how is this supposed to do anything useful for the mouse script?
@Ghabry those lines are not needed (I mistakenly added them), unless unlocked resolution is used. they are irrelevant to ruby. "dm" is a structure, that defines a display mode. http://www-personal.umich.edu/~bazald/l/api/struct_s_d_l___display_mode.html
https://www.git-tower.com/learn/git/faq/git-force-push
please use this method to amend your PR.
There is no need to amend my PR. After further testing, the mouse script(s) will override the initial setting and enable mouse support even if it is disabled in mkxp.conf. -I'll probably remove it from my repository too.
ps. you can close this PR.
Enables mouse support for games that use Shaz's Super Simple Mouse System.