search

Ancurio / mkxp

Free Software implementation of the Ruby Game Scripting System (RGSS)
GNU General Public License v2.0
524 stars 137 forks source link

BGM looping tag support (RPGVXAce) #77

Closed dogtopus closed 9 years ago

dogtopus commented 9 years ago

The BGM files included in the RPGVXAce RTP have 2 tags that control the looping. They are stored as comments and can be easily retrieved using libvorbisfile/vorbiscomment tool. For example, this is the looping tag from Theme1.ogg:

$ vorbiscomment -l Theme1.ogg
LOOPSTART=633744
LOOPLENGTH=3549181

The LOOPSTART is the offset of where the loop starts (in number of samples), and the LOOPLENGTH is the length of the loop (also in number of samples)

Ancurio commented 9 years ago

Yes: https://github.com/Ancurio/mkxp/blob/master/src/vorbissource.cpp#L134

Edit: Sorry, did you have any questions regarding the implementation?

dogtopus commented 9 years ago

Nope. I found this issue when I was testing mkxp with games made with different versions of RPG Makers. Then I decided to file a ticket here just in case if you don't know it already

Ancurio commented 9 years ago

So you are saying the ogg looping is not working correctly for you with mkxp? Could you provide a sample file which doesn't loop correctly?

dogtopus commented 9 years ago

Sorry, I think I made a mistake. I specified a wrong RTP path which contains all the RTP BGMs in MP3 format (which was built for some sort of testing purpose long time ago) so that's why it isn't looping You may close this issue now

Ancurio commented 9 years ago

No problem =)