search

AndBM / helichrysum

http://abmichelsen.com/helichrysum/
GNU General Public License v3.0
0 stars 1 forks source link

Fix cards #14

Closed alexrutar closed 2 years ago

alexrutar commented 2 years ago

Here's a starting point to include the site images. I've downloaded all the card images from the suggested location, and also fixed some naming issues.

alexrutar commented 2 years ago

There also seems to be an error in the parser, since the vision naming is wrong: the visions here should be Faith, Rebellion, Sanctuary, and Conquest

alexrutar commented 2 years ago

The savestring from your other game would be useful for testing. For convenience I'm leaving it here:

030303000613The First Chronicle3A0200012345133111E910CE2AE3000AE5FF07FFFFDD12FFFFFF0CD0DCFF23FFFFFF08C770FF36847714AF870828D4D66E047C8FD2D3059B09AAD5248CC00C1C335D32302BA4181E590B0E131D3D2D9C379DC517AB2C349E011B167F201E252758121F290D0F350015075E220203061A212319882E267D2F901067B80FEBDFE8EDE7E1DBECE2EAE6DEE0DAE4002004Bock
AndBM commented 2 years ago

The Tribunal was missing from the cards folder and your "all cards" list. Not sure to check for other missing cards. How did you scrape the cards?

AndBM commented 2 years ago

Everything should be ready - feel free to take a last look for missing cards and check that the site compiles properly online (offline is fine but online hasn't compiled yet). Then we should merge.

alexrutar commented 2 years ago

I originally had pulled the card names from the outdated card lookup file, and then infilled anything I could see missing. I've now pulled all the card names from sites.js and cards.js, along with a couple additional modifications (visions, banners, etc.). and I checked that every name in that file was properly downloaded. Funnily enough, "The Tribunal" was the only one that was missing!

I've also touched up the script a bit, too. And the file all.txt now contains a proper list of all the cards (sorted by alphabetical order).

alexrutar commented 2 years ago

I just wonder if the links should link to the original source, instead of just to the root of the document? It might be a bit nicer.

Or we could remove the links entirely, and just use a <span> element with a mouseover property.

AndBM commented 2 years ago

What exactly do you mean link to the original source? From the other website? For the span method, feel free to change the implementation.

AndBM commented 2 years ago

I see what you mean now. I think this is the best way to also make it work on mobile, where you have to actually click it to get the hover image. I have changed it so that it does not send you to the top of the page when you click, instead it send you nowhere.

alexrutar commented 2 years ago

I tried implementing the span method, which worked well on my computer, but resulted in weird selection behaviour on mobile which I could not fix. I've reverted it for now and I'll see if I can make it work tomorrow.