search

AndBible / and-bible

AndBible: Bible Study
https://andbible.org
GNU General Public License v3.0
599 stars 198 forks source link

Double tap to full screen issue #1291

Open bvahedy opened 3 years ago

bvahedy commented 3 years ago

When double tapping to go to full screen the single click dialog modal pops up. I don't know if there is a way to avoid this issue, any ideas?

agrogers commented 3 years ago

Yes, that is a bit of pain. More unintended consequences :)

Adding a delay after the first click might be an option. But it will make the click a little less responsive. There might be a sweet spot where it can detect a double click but not feel slow?

I would probably just hide the bookmark action dialog when going full screen after a double-click. If they want to keep it open then they can use the '...' menu option.

Other thoughts here but i dont think they are too helpful either. https://stackoverflow.com/questions/43444307/android-avoid-calling-single-tap-twice-for-double-tap-without-using-onsingletap

www.TenOutOfTen.org https://www.TenOutOfTen.org @.*** (+61) 0477 174 193 (Australia) (+95) 09 250018669 (Myanmar)

On Sat, 10 Jul 2021 at 12:22, Ben @.***> wrote:

When double tapping to go to full screen the single click dialog modal pops up. I don't know if there is a way to avoid this issue, any ideas?

— You are receiving this because you are subscribed to this thread. Reply to this email directly, view it on GitHub https://github.com/AndBible/and-bible/issues/1291, or unsubscribe https://github.com/notifications/unsubscribe-auth/ADKGTJSYSBO3F4TJGDOTEDTTW6VGBANCNFSM5ADXU5PA .

tuomas2 commented 3 years ago

I made now solution that will delay modal 300 ms to detect doubleclicks. Let's see if it works or if it's too much delay...

timbze commented 3 years ago

I am not a fan of using delay. Reason is I think user would use single click 100 times for 1 double click. To delay those 99 times is not a good sacrifice IMO

I think better to just hide modal again if it's double click

If others don't agree then just close this again

tuomas2 commented 3 years ago

I could remove that delay if double-tap to fullscreen option is disabled

tuomas2 commented 3 years ago

Another click often hits the modal itself so it's tricky to do closing.

tuomas2 commented 3 years ago

I feel whole double tap to fullscreen is not very convenient these days.

agrogers commented 3 years ago

I reckon give it a go with your delay. Let's see how it feels first. It could be a simple solution and not too noticeable.

What about multi finger gestures to make it full screen? Even fewer people would find it then :)

www.TenOutOfTen.org https://www.TenOutOfTen.org @.*** (+61) 0477 174 193 (Australia) (+95) 09 250018669 (Myanmar)

On Sat, 10 Jul 2021 at 23:21, Tuomas Airaksinen @.***> wrote:

I feel whole double tap to fullscreen is not very convenient these days.

— You are receiving this because you commented. Reply to this email directly, view it on GitHub https://github.com/AndBible/and-bible/issues/1291#issuecomment-877637046, or unsubscribe https://github.com/notifications/unsubscribe-auth/ADKGTJQ6SLXKJSXYJNRY3DTTXBCNJANCNFSM5ADXU5PA .

tuomas2 commented 3 years ago

300ms is noticeable. And smaller delays did not work.

tuomas2 commented 3 years ago

very disturbing...

timbze commented 3 years ago

Could perhaps disable double-tap and just use the 3-dot menu item for it.

But then how to get out of full screen? I know some apps come out of full screen when swiping down from the top, but I think there should be some more obvious way to do it as well.

bvahedy commented 3 years ago

I like Andrew's idea about two finger swip expand gesture to entet full screen.

On Sat, Jul 10, 2021, 8:00 AM Timmy Braun @.***> wrote:

Could perhaps disable double-tap and just use the 3-dot menu item for it.

But then how to get out of full screen? I know some apps come out of full screen when swiping down from the top, but I think there should be some more obvious way to do it as well.

— You are receiving this because you authored the thread. Reply to this email directly, view it on GitHub https://github.com/AndBible/and-bible/issues/1291#issuecomment-877651410, or unsubscribe https://github.com/notifications/unsubscribe-auth/ALCBRMIRYLU3YY6ODCNLYE3TXBOA5ANCNFSM5ADXU5PA .

timbze commented 3 years ago

The two finger expand / contract could be a good gesture for entering / exiting full screen.

Also, perhaps in full screen when tapping a verse, the modal should show an extra button for exit full screen

tuomas2 commented 3 years ago

But can't change until 4.1, because of help texts.

tuomas2 commented 3 years ago

What we could consider is to disable double-tap to fullscreen by default (users can re-toggle it and have modal delay then)

timbze commented 3 years ago

What we could consider is to disable double-tap to fullscreen by default (users can re-toggle it and have modal delay then)

I would be ok with that. But we'd still need a way to exit full screen

tuomas2 commented 3 years ago

Perhaps we should show toolbar when sliding down system toolbar somehow... Or auto-exit fullscreen if user does that. I'm not sure how to catch that event though.

tuomas2 commented 3 years ago

code in hideSystemUI and showSystemUI seems mostly deprecated BTW

bvahedy commented 3 years ago

We can forget about help text for now, how about displaying a return icon?

On Sat, Jul 10, 2021, 8:47 AM Tuomas Airaksinen @.***> wrote:

But can't change until 4.1, because of help texts.

— You are receiving this because you authored the thread. Reply to this email directly, view it on GitHub https://github.com/AndBible/and-bible/issues/1291#issuecomment-877658592, or unsubscribe https://github.com/notifications/unsubscribe-auth/ALCBRML6CWSULBUVMYGZ6L3TXBTQ3ANCNFSM5ADXU5PA .

bvahedy commented 3 years ago

I just discovered (ok I'm a bit slow) that if you double tap on a white space anywhere on the screen you will enter the full screen mode without bringing up the dialog. This works also in going back. We could leave it the way it is assuming users arrange there text to have empty white spaces on their screens. Any thoughts?

On Sat, Jul 10, 2021, 11:01 AM Ben @.***> wrote:

We can forget about help text for now, how about displaying a return icon?

On Sat, Jul 10, 2021, 8:47 AM Tuomas Airaksinen @.***> wrote:

But can't change until 4.1, because of help texts.

— You are receiving this because you authored the thread. Reply to this email directly, view it on GitHub https://github.com/AndBible/and-bible/issues/1291#issuecomment-877658592, or unsubscribe https://github.com/notifications/unsubscribe-auth/ALCBRML6CWSULBUVMYGZ6L3TXBTQ3ANCNFSM5ADXU5PA .

howdev commented 2 years ago

this is terrible. double tap work as it should before version 4. It is not practical to find an empty area to double tap to fullscreen, this is an app with full screen of text. The bookmark dialog should be as previous versions, tap and hold to bring it up, then you have no problem with double tap fullscreen. The tap once open bookmark dialog is problem in itself. Now you can't select more than one verse. Tap on the next verse, the dialog disappears. Instead of floating dialog blocking text, it should be fixed a the lower part of the screen, opens when tap and hold a verse

bvahedy commented 2 years ago

You can tap on the + icon on the dialog header to select multiple verses. Also, you can disable double tap to full screen in the application preferences.

howdev commented 2 years ago

@bvahedy yes I know you can, but that is a tiny + and definitely not even good as tap+hold then tap on more verses

agrogers commented 2 years ago

You can still tap+hold+drag. That functionality hasn't changed. Once you get your selection choose whether you want to bookmark a whole verse or the exact selection. This video demonstrates highlighting part of a verse only - but you do the same thing for multiple verses: https://www.youtube.com/watch?v=PXdvFRLGcAA

I understand these sorts of changes can be frustrating... but they are not made without lots of discussion and forethought. In this case it was felt that what was lost was outweighed by what was gained. There is no question in my mind having used the new version for over a year that I would not go back. And I think new users to the app would probably agree.