search

AndBible / and-bible

AndBible: Bible Study
https://andbible.org
GNU General Public License v3.0
551 stars 193 forks source link

Add the text searched in the find history.. #1340

Open bvahedy opened 2 years ago

bvahedy commented 2 years ago

Since searches are in the history, please add the text that was searched to the end of the word "find" in the history. for long text searched please truncated, so that is does not wrap. This way if there are multiple find in the history the user can select the desired search.

timbze commented 2 years ago

Relates to #831

bvahedy commented 2 years ago

Yes, but #831 doesn't say how to improve it. May be that is why it hasn't been implemented or looked at. I feel it's an important mod. Otherwise you just see the world find multiple times in the history without knowing which is the one you want to search again.

On Sat, Jul 17, 2021, 8:37 AM Timmy Braun @.***> wrote:

Relates to #831 https://github.com/AndBible/and-bible/issues/831

— You are receiving this because you authored the thread. Reply to this email directly, view it on GitHub https://github.com/AndBible/and-bible/issues/1340#issuecomment-881916339, or unsubscribe https://github.com/notifications/unsubscribe-auth/ALCBRMIKRC4IVJWM3ZINQU3TYGPU5ANCNFSM5AREVCTA .

timbze commented 2 years ago

I just added the note for reference. When someone looks at #831 or wants to work on it, they should see this as well.

bvahedy commented 2 years ago

Ok, thank you.

On Sat, Jul 17, 2021, 10:05 AM Timmy Braun @.***> wrote:

I just added the note for reference. When someone looks at #831 https://github.com/AndBible/and-bible/issues/831 or wants to work on it, they should see this as well.

— You are receiving this because you authored the thread. Reply to this email directly, view it on GitHub https://github.com/AndBible/and-bible/issues/1340#issuecomment-881927962, or unsubscribe https://github.com/notifications/unsubscribe-auth/ALCBRMMXAFZ645I5EM7XQW3TYGZ3XANCNFSM5AREVCTA .

agrogers commented 2 years ago

I have had a look at this and it seems that the 'Find' history item is added when the Find window is opened not when the Find is executed. So there is no easy fix for this one.

I am not sure how the history interacts and I fear that forcing another history item into the list when a find is executed may mess with the Back button operation. I have added a different issue to try and address the order #2026. I can then look at integrating it better with the search.