search

AndBible / and-bible

AndBible: Bible Study
https://andbible.org
GNU General Public License v3.0
589 stars 197 forks source link

Speak button should not start speaking immediately #1431

Open tuomas2 opened 3 years ago

tuomas2 commented 3 years ago

In 1-click modal, speak button should only display speak transport and prepare for speaking for selected verse.

(this was somewhere as a comment, but did not find now...)

bvahedy commented 3 years ago

How about adding a switch in the app settings to play immediately or just bring up the speak toolbar. It would then be on tap instead of two taps. I know you don't want accidental play when you are sitting in a church but that's once or twice a week for some. For those who use the speak everyday, perhaps due to visual impairment, it makes more sense to use one tap, especially since it works like that in the 3.3 production build.

On Tue, Jul 27, 2021, 12:13 AM Tuomas Airaksinen @.***> wrote:

In 1-click modal, speak button should only display speak transport and prepare for speaking for selected verse.

(this was somewhere as a comment, but did not find now...)

— You are receiving this because you are subscribed to this thread. Reply to this email directly, view it on GitHub https://github.com/AndBible/and-bible/issues/1431, or unsubscribe https://github.com/notifications/unsubscribe-auth/ALCBRMJH62CBZRXXM6IXATDTZZMDNANCNFSM5BBTQNSA .

tuomas2 commented 3 years ago

Maybe. Default anyway should be not to start immediately.

agrogers commented 3 years ago

How about adding a long press on the speak button that speaks automatically?

www.TenOutOfTen.org https://www.TenOutOfTen.org @.*** (+61) 0477 174 193 (Australia) (+95) 09 250018669 (Myanmar)

On Tue, 27 Jul 2021 at 17:36, Tuomas Airaksinen @.***> wrote:

Maybe. Default anyway should be not to start immediately.

— You are receiving this because you are subscribed to this thread. Reply to this email directly, view it on GitHub https://github.com/AndBible/and-bible/issues/1431#issuecomment-887284191, or unsubscribe https://github.com/notifications/unsubscribe-auth/ADKGTJTIVWBSIEOCAA3SDTLTZZOYDANCNFSM5BBTQNSA .

tuomas2 commented 3 years ago

Long-press toolbar button opens speak activity, and I think it's good that way. But for 1-clik modal maybe.

agrogers commented 3 years ago

Oh, so it does. I didnt hold for long enough.

You can get to the Speak Activity from the cog in the bottom right corner. Maybe that is sufficient.

www.TenOutOfTen.org https://www.TenOutOfTen.org @.*** (+61) 0477 174 193 (Australia) (+95) 09 250018669 (Myanmar)

On Tue, 27 Jul 2021 at 18:02, Tuomas Airaksinen @.***> wrote:

Long-press toolbar button opens speak activity, and I think it's good that way. But for 1-clik modal maybe.

— You are receiving this because you commented. Reply to this email directly, view it on GitHub https://github.com/AndBible/and-bible/issues/1431#issuecomment-887300096, or unsubscribe https://github.com/notifications/unsubscribe-auth/ADKGTJT3H5I2OONEFSSTWG3TZZRZLANCNFSM5BBTQNSA .