AndBible / and-bible

AndBible: Bible Study
https://andbible.org
GNU General Public License v3.0
599 stars 198 forks source link

UI to enable / disable installed add-ons per workspace/window #1448

Open tuomas2 opened 3 years ago

tuomas2 commented 3 years ago

I'm thinking plugins should not automatically apply to all windows everywhere. They should be configurable per workspace/window. I.e. we should add one more text option for them: "Enable plugins", which would give a multi-selectable list of plugins.

In addition, we still need some plugins to be configured globally, not per-workspace/per-window basis (like RefParser). Thus, there should be "Enable plugins globally" option in app preferences.

agrogers commented 3 years ago

I don't really know what add ons you guys have in mind. But I wonder whether they should automatically apply to all Windows and workspaces with an option to make them apply to a selection.

Or perhaps when a new add on is installed it applies to all areas and the user has to deselect it. Or perhaps they get a choice at install.

Just don't want a user to install an add on and then not have it work because there is another setting somewhere that they need to enable.

tuomas2 commented 3 years ago

Good point. But if plugin is manipulating how UI will look like, I think it makes sense user might want to enable something in some workspace/window but not in some else? Similarly as per-window color adjustments etc?

tuomas2 commented 3 years ago

For now (4.0) it's all global (and hopefully not too much abused).

Remember that when doing any tutorial videos, styling plugins should be uninstalled :-D

agrogers commented 3 years ago

Yes, I think it is a good feature. Just need to help the user enable it where they want it. Could be confusing if some add ons work everywhere always and others don't.

On Fri, 30 Jul 2021, 5:56 pm Tuomas Airaksinen, @.***> wrote:

Good point. But if plugin is manipulating how UI will look like, I think it makes sense user might want to enable something in some workspace/window but not in some else? Similarly as per-window color adjustments etc?

— You are receiving this because you commented. Reply to this email directly, view it on GitHub https://github.com/AndBible/and-bible/issues/1448#issuecomment-889708550, or unsubscribe https://github.com/notifications/unsubscribe-auth/ADKGTJTJFO6UQ6VSUNXLPLLT2JLMFANCNFSM5BHZXQ4A .

tuomas2 commented 3 years ago

Perhaps it could be other way around: everything is enabled by default and there's per-workspace/per-window option to disable some of them. Similar logic as with hiding specific bookmark labels.

agrogers commented 3 years ago

I like it. Although I always prefer options that are positive (tick and it is in/true) rather than tick and it is false. They feel counterintuitive that way.

Perhaps

On Fri, 30 Jul 2021, 6:01 pm Tuomas Airaksinen, @.***> wrote:

Perhaps it could be other way around: everything is enabled by default and there's per-workspace/per-window option to disable some of them. Similar logic as with hiding specific bookmark labels.

— You are receiving this because you commented. Reply to this email directly, view it on GitHub https://github.com/AndBible/and-bible/issues/1448#issuecomment-889713931, or unsubscribe https://github.com/notifications/unsubscribe-auth/ADKGTJSAZSOCYGOOEB6WAEDT2JL6NANCNFSM5BHZXQ4A .