search

AndBible / and-bible

AndBible: Bible Study
https://andbible.org
GNU General Public License v3.0
600 stars 198 forks source link

Fresh new layout for homepage (andbible.github.io) #1608

Closed tuomas2 closed 3 years ago

BryceSteuer commented 3 years ago

How about this so far, applying all your suggestions (I also make sure it works for smaller screens even less than 300px and even on Chrome too).

The sidebar in smaller screens is hidden because it would by default float to the bottom and run right next to the other round icons that display pretty much the same thing. I would however like to keep it for larger screens as I think it is a concise summary one can see without having to scroll through the whole page.

About the image gallery enlarger (I think it's called a lightbox) - I'm not so great in JS either so I may get some code from w3schools and tweak it to the page's needs.

I also have plans to fix the counter up a bit, including your appropriate suggestion in that regard.

Thanks for the compliments, but honestly and strictly this is not a from-scratch webpage; I took the original one and made my own additions and deletions to it. image

agrogers commented 3 years ago

Hi Bryce. Thanks for this. I will try and have a good look soon.

On Sat, 25 Sept 2021 at 07:50, Bryce Steuer @.***> wrote:

How about this so far, applying all your suggestions (I also make sure it works for smaller screens even less than 300px and even on Chrome too). The sidebar in smaller screens is hidden because it would by default float to the bottom and run right next to the other round icons that display pretty much the same thing. I would however like to keep it for larger screens as I think it is a concise summary one can see without having to scroll through the whole page. About the image gallery enlarger (I think it's called a lightbox) - I'm not so great in JS either so I may get some code from w3schools https://www.w3schools.com/howto/tryit.asp?filename=tryhow_css_js_lightbox and tweak it to the page's needs.

Thanks for the compliments, but honestly and strictly this is not a from-scratch webpage; I took the original one and made my own additions and deletions to it. [image: image] https://user-images.githubusercontent.com/48736452/134743014-c6711606-5878-40fd-acb6-6a4c2c06581e.png

— You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub https://github.com/AndBible/and-bible/issues/1608#issuecomment-926938027, or unsubscribe https://github.com/notifications/unsubscribe-auth/ADKGTJSZ7TSE2U4P2P4B3VTUDTXB7ANCNFSM5CQTO73A .

BryceSteuer commented 3 years ago

I hope to PR either Oct 4 or 5 (hopefully the 4th), with the last edition. It will be styled for screens 300px+ in width (the narrowest screen now is 320px, so the page will display correctly on all devices). Also I implemented AG's suggestions, including a gallery viewer for screens narrower than 800px, commas in the counter, new videos, etc. Also I plan to implement some key user reviews in a forefront position on the page before PR'ing. Just a heads up, that's my plan if the Lord wills.

agrogers commented 3 years ago

Great. I will try and check it today after church

On Sun, 3 Oct 2021, 5:46 am Bryce Steuer, @.***> wrote:

I hope to PR either Oct 4 or 5 (hopefully the 4th), with the last edition. It will be styled for screens 300px+ in width (the narrowest screen now is 320px, so the page will display correctly on all devices). Also I implemented AG's suggestions, including a gallery viewer for screens narrower than 800px, commas in the counter, new videos, etc. Also I plan to implement some key user reviews in a forefront position on the page before PR'ing. Just a heads up, that's my plan if the Lord wills.

— You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub https://github.com/AndBible/and-bible/issues/1608#issuecomment-932811178, or unsubscribe https://github.com/notifications/unsubscribe-auth/ADKGTJXAJUJCMN7YD3KS5TTUE5OSJANCNFSM5CQTO73A .

agrogers commented 3 years ago

Hi Bryce

I couldn't find your latest changes. Have you published them into a repository that you own?

Thanks andrew

www.TenOutOfTen.org https://www.TenOutOfTen.org @.*** (+61) 0477 174 193 (Australia) (+95) 09 250018669 (Myanmar)

On Sun, 3 Oct 2021 at 08:20, Andrew Rogers @.***> wrote:

Great. I will try and check it today after church

On Sun, 3 Oct 2021, 5:46 am Bryce Steuer, @.***> wrote:

I hope to PR either Oct 4 or 5 (hopefully the 4th), with the last edition. It will be styled for screens 300px+ in width (the narrowest screen now is 320px, so the page will display correctly on all devices). Also I implemented AG's suggestions, including a gallery viewer for screens narrower than 800px, commas in the counter, new videos, etc. Also I plan to implement some key user reviews in a forefront position on the page before PR'ing. Just a heads up, that's my plan if the Lord wills.

— You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub https://github.com/AndBible/and-bible/issues/1608#issuecomment-932811178, or unsubscribe https://github.com/notifications/unsubscribe-auth/ADKGTJXAJUJCMN7YD3KS5TTUE5OSJANCNFSM5CQTO73A .

BryceSteuer commented 3 years ago

AG Rogers, I push my changes to this (my clone of the official andbible.github.io). From there I will PR when all changes are complete, hopefully either today or tomorrow. Sorry if I was misunderstood in any way.

bvahedy commented 3 years ago

Bryce, it looks good but the top image is cutoff to the right: Screenshot_20211004-092326_Samsung Internet

timbze commented 3 years ago

@bvahedy that is still the original site. Bryce's changes are only on his repo, and not visible easily yet. You have to download his branch and check it on your computer for now

tuomas2 commented 3 years ago

BTW Bryce could set up github.io hosting for his development version so that we could see it in action

tuomas2 commented 3 years ago

how to do it: read here https://pages.github.com/

BryceSteuer commented 3 years ago

image What does it mean here that my changes may be overwritten? Am I on track here?

BryceSteuer commented 3 years ago

I guess that figured itself out, here is the link: https://brycesteuer.github.io/andbible.github.io/

bvahedy commented 3 years ago

Now that looks beautiful. Great job Bryce, I like the counters up front.

On Mon, Oct 4, 2021, 10:25 AM Bryce Steuer @.***> wrote:

I guess that figured itself out, here is the link: https://brycesteuer.github.io/andbible.github.io/

— You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub https://github.com/AndBible/and-bible/issues/1608#issuecomment-933696225, or unsubscribe https://github.com/notifications/unsubscribe-auth/ALCBRMIFT3RY5QBOBPK26KDUFHPQPANCNFSM5CQTO73A . Triage notifications on the go with GitHub Mobile for iOS https://apps.apple.com/app/apple-store/id1477376905?ct=notification-email&mt=8&pt=524675 or Android https://play.google.com/store/apps/details?id=com.github.android&referrer=utm_campaign%3Dnotification-email%26utm_medium%3Demail%26utm_source%3Dgithub.

timbze commented 3 years ago
  1. Get it on "Google" should probably rather be on "Play Store" or "Google Play"
  2. "For idea requests or bugs in the app" could be "For ideas, feature requests or bugs in the app"
  3. "Alternatively e-mail" could be "Alternatively, contact us via email at"
  4. I'm wondering if Google discussion group should be secondary after Telegram and Matrix, but I guess that doesn't matter much
  5. I think for enhancements, instead of "please email And Bible Support" it might be better to change to "Please add a comment on an issue you want to work with or email And Bible support"
tuomas2 commented 3 years ago

User count is indeed cool but we don't know how many users we have. We have some clue about Google Play users (it's bit less than 70k devices that have AB installed according to Google Play). Yes it says 100k+ downloads, but that does not equal with number of users necessarily (uninstalling users also count in downloads).

agrogers commented 3 years ago

Yes, looking good Bryce. Thanks

This video is an old one [image: image.png] And some images have got stretched out of their original ratio. Just need to remove either the width or the height property. [image: image.png]

www.TenOutOfTen.org https://www.TenOutOfTen.org @.*** (+61) 0477 174 193 (Australia) (+95) 09 250018669 (Myanmar)

On Tue, 5 Oct 2021 at 04:14, Tuomas Airaksinen @.***> wrote:

User count is indeed cool but we don't know how many users we have. We have some clue about Google Play users (it's bit less than 70k devices that have AB installed according to Google Play). Yes it says 100k+ downloads, but that does not equal with number of users necessarily (uninstalling users also count in downloads).

— You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub https://github.com/AndBible/and-bible/issues/1608#issuecomment-933732941, or unsubscribe https://github.com/notifications/unsubscribe-auth/ADKGTJRNRC4GQ5UNRAR65TLUFHVJLANCNFSM5CQTO73A .

BryceSteuer commented 3 years ago

@bvahedy Thank you very much. I am glad to use what skills I have to glorify God and serve others. @timbze Those all sound like good suggestions; I plan to implement them all. @tuomas2 Do you recommend completely removing that section of the counter, or merely changing it to something like 70k+? @agrogers I will remove the old video, also the last image of the stretched images is not working for me to view. What screen width are you viewing it on when you encounter that issue?

timbze commented 3 years ago

Re: stretched (501 pixels width). It also did look a bit stretched on my regular screen with 1920px, but I wasn't 100% sure so I hadn't mentioned anything. Screenshot from 2021-10-05 11-52-09 )

BryceSteuer commented 3 years ago

Thanks for that. I had put checks against stretch in place, but apparently they only work for 500px or less. My laptop is only 1400px long, so if you have any insights from a 1900px screen freely let me know and I will try addressing it.

BryceSteuer commented 3 years ago

For some reason embedding the new playlists is fruitless, even though following the link directly leads to the newer playlist the actual embedded playlist is the older one from version 3.3 for some reason I cannot explain. So I will just embed a few individual tutorial videos unless anyone else has input on how to fix this strange issue. Hopefully can figure out issues or can PR now if you want,if not now then have to be in about 24 hours.

agrogers commented 3 years ago

Good point. Tuomas, can we make all new videos viewable now?

www.TenOutOfTen.org https://www.TenOutOfTen.org @.*** (+61) 0477 174 193 (Australia) (+95) 09 250018669 (Myanmar)

On Wed, 6 Oct 2021 at 07:14, Bryce Steuer @.***> wrote:

It may be because the newer videos are unlisted...

— You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub https://github.com/AndBible/and-bible/issues/1608#issuecomment-934850936, or unsubscribe https://github.com/notifications/unsubscribe-auth/ADKGTJSPGRM5SQUKX5FMKQLUFNTEVANCNFSM5CQTO73A .

tuomas2 commented 3 years ago

@BryceSteuer try this link https://www.youtube.com/embed/videoseries?list=PLD-W_Iw-N2Mn5N3KSmNsb2IuBbR1XVLke

Maybe you have tried "All Tutorials" playlist, which indeed has old tutorials in the beginning.

tuomas2 commented 3 years ago

@agrogers all tutorials are viawable and appear in playlists. I have revealed them to "public" one by one, and I think it's good to do that way because we don't have too much "regular content" to channel audience otherwise. We could also schedule them to be released in this manner.

tuomas2 commented 3 years ago

My comments

agrogers commented 3 years ago

I like the number counter. Let's just make it as accurate as possible. 70,000+ is good.

www.TenOutOfTen.org https://www.TenOutOfTen.org @.*** (+61) 0477 174 193 (Australia) (+95) 09 250018669 (Myanmar)

On Thu, 7 Oct 2021 at 16:28, Tuomas Airaksinen @.***> wrote:

My comments

  • Google Discuss -> Google Groups, change icon to Google Groups icon (it's now hangouts icon)
  • Email us: link takes to Google Play. Should go to @.***
  • Google Play link: change to Google Play actual icon (now Chromebook or some old icon)
  • F-droid also could have actual icon that F-droid uses
  • "Get it on Amazon kindle" -> "Get it from Amazon App Store" (it is available to other devices too, and soon to Windows 11).
  • Page coloring: pick colors from icon and use other colors that fit well. If you have trouble finding good ones, I can consult my wife, she had influenced greatly when choosing the colors to the icon :-) Especially Green background color in "Download" buttons does not look pleasing to me.
  • I would try if it looks better with brown primary menu bar 100% wide. Or could try making black header as wide as brown one.
  • User count: either 70,000+ or not at all. @agrogers https://github.com/agrogers opinion about this?
  • Black background header could look better if centered (like brown menu bar is)
  • Perhaps adding left padding to screenshots would make them look better under their titles (also other content that is under (sub)titles).

— You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub https://github.com/AndBible/and-bible/issues/1608#issuecomment-937490126, or unsubscribe https://github.com/notifications/unsubscribe-auth/ADKGTJRIUJJLSPYRAQZCEA3UFU4YNANCNFSM5CQTO73A .

tuomas2 commented 3 years ago

Let's put 60,000+ Because it's actually 68,567 as of today.

BryceSteuer commented 3 years ago

Tuomas, I have implemented all of your suggestions save one, that is the colors for the sidebar buttons. If you could consult your wife about that I think it would be much better. When reviewing the page I did think the light green especially looked a bit childish or gaudy, but I thought to leave it so unless you or another developer disagree.

BryceSteuer commented 3 years ago

Another thing - the last issue I am aware of - is that the tablet images (Only shown on screens wider than 900px) are low-res image

timbze commented 3 years ago

The links toward the end under "Helping" don't open in new tab. I think they should. I checked some other links that did but have not checked the whole page.

BryceSteuer commented 3 years ago

Ok, I will make sure all <a> have target="_blank" attribute. Edit: Now fixed.

tuomas2 commented 3 years ago

Email link is not working. url should be mailto:help.andbible@gmail.com

Looks better now after changes!

BryceSteuer commented 3 years ago

Fixed email in latest commit. I think the only questionable items left are the colors on the sidebar links, and the low-res tablet images (maybe omit tablet images for now?). Unless anyone else has any more input I've overlooked.

tuomas2 commented 3 years ago

Allright I guess I can merge this now. Improvements can be made later as separate PRs.

tuomas2 commented 3 years ago

Thank you for doing this!

Related PR now merged: https://github.com/AndBible/andbible.github.io/pull/4

tuomas2 commented 3 years ago

And then also this. https://github.com/AndBible/andbible.github.io/pull/5

BryceSteuer commented 3 years ago

Thanks, I was glad to help. Let me know when you are ready to do some minor fixes and PR in the future.