search

AndBible / and-bible

AndBible: Bible Study
https://andbible.org
GNU General Public License v3.0
577 stars 193 forks source link

Night mode toggle should be enabled always (just notifying user if non-system setting is being used) #1641

Open tuomas2 opened 3 years ago

tuomas2 commented 3 years ago

It is shown only if night mode switching is set to "manual". In system and automatic mode it is hidden. Though it probably would be better to show it, just not have it enabled.

Originally posted by @tuomas2 in https://github.com/AndBible/and-bible/issues/1640#issuecomment-907592719

bvahedy commented 3 years ago

Can we also make the change of they tap on it and it's greyed out a toast message would tell them to change app settings to manual. Or some msg like that.

On Sat, Aug 28, 2021, 2:09 AM Tuomas Airaksinen @.***> wrote:

Closed #1641 https://github.com/AndBible/and-bible/issues/1641 via 449ded8 https://github.com/AndBible/and-bible/commit/449ded8d51378fcb31cd921d8e2cf48e314f1874 .

— You are receiving this because you are subscribed to this thread. Reply to this email directly, view it on GitHub https://github.com/AndBible/and-bible/issues/1641#event-5221523702, or unsubscribe https://github.com/notifications/unsubscribe-auth/ALCBRMPZMM5HANEW7Q3TY7TT7CRV3ANCNFSM5C64G3VA . Triage notifications on the go with GitHub Mobile for iOS https://apps.apple.com/app/apple-store/id1477376905?ct=notification-email&mt=8&pt=524675 or Android https://play.google.com/store/apps/details?id=com.github.android&referrer=utm_campaign%3Dnotification-email%26utm_medium%3Demail%26utm_source%3Dgithub.

tuomas2 commented 3 years ago

Or should we make it so that it actually stays enabled, but switching it will change night mode to "manual" (and toast user about it)?

Anyway, we can't create new toasts without new strings, so -> 4.1.

agrogers commented 3 years ago

I like the last suggestion.

www.TenOutOfTen.org https://www.TenOutOfTen.org @.*** (+61) 0477 174 193 (Australia) (+95) 09 250018669 (Myanmar)

On Mon, 30 Aug 2021 at 16:31, Tuomas Airaksinen @.***> wrote:

Or should we make it so that it actually stays enabled, but switching it will change night mode to "manual" (and toast user about it)?

Anyway, we can't create new toasts without new strings, so -> 4.1.

— You are receiving this because you are subscribed to this thread. Reply to this email directly, view it on GitHub https://github.com/AndBible/and-bible/issues/1641#issuecomment-908069225, or unsubscribe https://github.com/notifications/unsubscribe-auth/ADKGTJWJQOYGIE4AHFBBAVLT7MQUFANCNFSM5C64G3VA .