AndBible / and-bible

AndBible: Bible Study
https://andbible.org
GNU General Public License v3.0
551 stars 193 forks source link

Unpinned window sync/nonsync issue #1671

Open timbze opened 2 years ago

timbze commented 2 years ago

Describe the bug A nonsync window can cause other sync windows to change to nonsync passage

Bug was found on And Bible version Build 544

I got this issue, then tried to reproduce with these steps and it didn't reproduce. I'll try some more and see if I can get the steps right Update: I think with these steps it can be reproduced anytime

To Reproduce Steps to reproduce the behavior:

  1. Open these windows: -> 1. Pinned synced KJV to Romans 1 -> 2. Unpinned synced window (some other different syncable document) -> 3. Unpinned unsynced window (some other different syncable document) (open to Romans 2) -> 4. Unpinned synced window (some other different syncable document)
  2. Open just window 1 and 2
  3. Copy workspace as new and open new workspace
  4. Open window 3, window 2 is hidden
  5. Open window 4 -> problem: it opens to Romans 2 -> expected: it should open to Romans 1
timbze commented 2 years ago

Reproduced after copying workspace as new

https://support.andbible.org/scp/tickets.php?id=751

tuomas2 commented 1 year ago

Could not reproduce (on emulator). Only difference that used NASb instead of KJV. Trying with KJV...

tuomas2 commented 1 year ago

Could not reproduce. Tried with KJV and windows 2-4 were KingComments.

tuomas2 commented 1 year ago

Can you try to reproduce this again with recent version and post logcat?

tuomas2 commented 1 year ago

I believe this has exactly same root cause as #2208. Just replace restarting app with creation / switching to another workspace.

timbze commented 1 year ago

I can not reproduce in 650 either. I wonder if the issue has been fixed by some other fix?

tuomas2 commented 1 year ago

I believe its still there. I got it many times daily in reformation conference in july (no significant changes since then) .