AndBible / and-bible

AndBible: Bible Study
https://andbible.org
GNU General Public License v3.0
558 stars 193 forks source link

Allow user to disable "upgrade webview" message #1889

Open timbze opened 2 years ago

timbze commented 2 years ago

For some users the webview works partially (webview version 52 is that way). Modals don't show correctly but Bible text works and links can be clicked.

On some devices it's impossible to upgrade webview unless the OS provider updates it with OS update (e.g. Kindle and Teclast tablets)

In such case the user may want to disable the message since they know about the problem but want to use as is anyway.

I think the message should possibly only be disabled in Application preferences > advanced settings. And also the setting should only show if webview is lower then supported setting. That way the user will not mistakenly disable the message when it shows and then later complain that something is not working.

This support ticket is such a request. https://support.andbible.org/scp/tickets.php?id=966

timbze commented 2 years ago

For reference, this is what webview v52 does (other modals do the same thing):

image

tuomas2 commented 2 years ago

I kind of think that it might be good idea to remind user about webview issue, because he might forget that and wonder how things don't work as expected. It should be smaller annoyance to press "proceed" button on every startup than having all these unexpected issues.

RepentAndBelieveTheGospel commented 2 years ago

I would like to request a checkbox to disable this WebView notification. I have a Huawei phone which doesn't have any Google Services. From what I understand, this WebView package depends on GMS to work properly. The functionality I am using is working and I don't want to be reminded everytime about the WebView package. Please allow me to decide if I want to be notified or not.

Screenshot_20211203_171512_net bible android activity_edit_193221332167912

timbze commented 2 years ago

@RepentAndBelieveTheGospel do you have the latest version of And Bible installed? There was a "fix" put in so that Huawei phones should not show this message at all, because they have different version numbers for webview. This fix should be available in 4.0.619. Ref #1932

tuomas2 commented 2 years ago

fix should be released to huawei app gallery already

RepentAndBelieveTheGospel commented 2 years ago

fix should be released to huawei app gallery already

I have downloaded this version from APKPure. Version 4.0.621 doesn't show in AppGallery yet. The issue is still there.

photo_2021-12-03_18-19-04

tuomas2 commented 2 years ago

hmm maybe needs another fix then. can you do bug report from main menu or post your logcat here

RepentAndBelieveTheGospel commented 2 years ago

hmm maybe needs another fix then. can you do bug report from main menu or post your logcat here

logcat.txt.gz

tuomas2 commented 2 years ago

Thank you. Got it fixed, will be released in 1 week (if not already today).

RepentAndBelieveTheGospel commented 2 years ago

Thank you. Got it fixed, will be released in 1 week (if not already today).

Updated to 4.0.628 now and that annoying message is gone. Thank you!