Open didib opened 2 years ago
bvahedy
commented
2 years ago Are you saying that you use a Bible module that has only the OT and not NT books. But a bookmark has a ref link to the NT within it and when you tap on the link it tries to go to the NT ref but it can't find it. Am I understanding you correctly?
didib
commented
2 years ago Exactly.
bvahedy
commented
2 years ago I just tried that and it does work, make sure your ref in the bookmark is correctly typed. Use the icon with the cross in the edit mode in the note window to select the ref link instead of typing the ref manually.
didib
commented
2 years ago Well, doesn't work for me - perhaps I am missing something. I do not type a ref to create a bookmark - I tap a verse and then tap the "+ bookmark" icon in the popup.
bvahedy
commented
2 years ago Can you take a screenshot of the page with the verse and also the screenshot of what is in the bookmark that has the reference.
agrogers
commented
2 years ago Hi
I think what is happening is that when a bookmark is selected from the Menu
Bookmarks list that is for a verse that does not exist in the current translation (eg Exodus 1:1 in PEV) it says 'Exodus 1 not found in this document'.
To view the bookmarked verse you need to then select a transition that includes Exodus 1.
What would seem to make more sense would be to change the translation to the one used when the bookmark was created. The user is going to have to do that manually so why not save them a step.
I believe I have proposed something like this once before.
Is this the issue we are addressing here?
On Mon, 22 Nov 2021, 2:12 am Ben, @.***> wrote:
Can you take a screenshot of the page with the verse and also the screenshot of what is in the bookmark that has the reference.
— You are receiving this because you are subscribed to this thread. Reply to this email directly, view it on GitHub https://github.com/AndBible/and-bible/issues/1952#issuecomment-974846495, or unsubscribe https://github.com/notifications/unsubscribe-auth/ADKGTJXVASOFHEGFVXBLGKLUNEK55ANCNFSM5IL33OGA .
cmahte
commented
2 years ago A dozen years or so ago, I was studying the Apostles' Bible (OT only) bible and EMTV (NT nnly) as a single translation by Paul Esposito. Similar crashes and "not found" issues like what is reported here bugged me enough that I eventually just dropped the files from the EMTV into the Apostles Bible folder, and all the issues disappeared. It made it much easier to search the work, etc.
I liked it so much I reported it to Crosswire as a bug and tried to get the work listed as the LOGOS Bible (that's what Esposito called the combination.) That didn't happen, but combining an OT work and an NT work in a single folder still does. That is, as long as you have 1 OT Only work, and 1 NT only work, you can just put the files for each into a single folder and the result works, as long as they were created in a similar way (zipped or raw.... etc. but most are.) You probably want to pay close attention to the versification used, and go with the Old Testament folder rather New Testament (OT versification systems vary a LOT more than NT... much less likely to crash.)
Applying this to AndBible may be tricky, but if you can navigate with a file manager to your local sword repo, and either link or copy the files from the NT work to the OT work, it should solve the problem, but you have to remember that when you're in Matthew of the MAPM, it's really Matthew of the HebDelitzsch... (or is that the reverse?)
But this is a hack, not a fix for your issue. You'll have to always remember that updates to the work you moved will not show up in the other work until you re-copy them.
NOTE: The EMTV currently has a file 'ot.bzv' in it.. obviously when you copy, only copy the NT files ... not the (nearly) empty OT files if they exist.
On Sun, Nov 21, 2021 at 3:28 PM Andrew Rogers @.***> wrote:
Hi
I think what is happening is that when a bookmark is selected from the Menu
Bookmarks list that is for a verse that does not exist in the current translation (eg Exodus 1:1 in PEV) it says 'Exodus 1 not found in this document'.
To view the bookmarked verse you need to then select a transition that includes Exodus 1.
What would seem to make more sense would be to change the translation to the one used when the bookmark was created. The user is going to have to do that manually so why not save them a step.
I believe I have proposed something like this once before.
Is this the issue we are addressing here?
On Mon, 22 Nov 2021, 2:12 am Ben, @.***> wrote:
Can you take a screenshot of the page with the verse and also the screenshot of what is in the bookmark that has the reference.
— You are receiving this because you are subscribed to this thread. Reply to this email directly, view it on GitHub < https://github.com/AndBible/and-bible/issues/1952#issuecomment-974846495>, or unsubscribe < https://github.com/notifications/unsubscribe-auth/ADKGTJXVASOFHEGFVXBLGKLUNEK55ANCNFSM5IL33OGA
.
— You are receiving this because you are subscribed to this thread. Reply to this email directly, view it on GitHub https://github.com/AndBible/and-bible/issues/1952#issuecomment-974898932, or unsubscribe https://github.com/notifications/unsubscribe-auth/AC2DE4XPFBNS5BGOUUSLUFLUNFQAHANCNFSM5IL33OGA . Triage notifications on the go with GitHub Mobile for iOS https://apps.apple.com/app/apple-store/id1477376905?ct=notification-email&mt=8&pt=524675 or Android https://play.google.com/store/apps/details?id=com.github.android&referrer=utm_campaign%3Dnotification-email%26utm_medium%3Demail%26utm_source%3Dgithub.
bvahedy
commented
2 years ago I created a bookmark for Gen. 6:1 and placed a link to Matthew 5:20 in a Bible module that has both OT and NT (like NASB). Then I opened a window with a Bible module like WLC which only has OT books and navigated to Gen 6:1. When I tapped on that verse note it shows the bookmark and the link. When I tap on the link it opens a linked window with the default Bible, which had already been set, and that Bible contains both OT and NT. I never got a not found error.
didib
commented
2 years ago My own flow is:
I don't use notes (here), nor write refs by myself anywhere. Just plain bookmarks. Now, if I am on the NT-only translation, and choose Menu->Bookmarks->bm1, I get the error as Andrew explained above. And if I am on the OT-only one, and choose bm2, I get the same error. My suggestion here is to automatically choose the correct translation.
Re putting both in the same folder: I didn't try this with the generated files, but I did play quite a lot with this at the time using the source OSIS files. I never managed to get to a point that satisfied me enough, around the versification.
bvahedy
commented
2 years ago Ok, I see what you are talking about. This would be more of a feature request since we would be forcing the active window to change to a different Bible module based on the bookmark. But that would also mean that we would have to store the bible module in the database with the bookmark. I not sure we would want to do that either, that could get really messy. We need @tuomas2 input on this.
didib
commented
2 years ago Yes, that's why I marked it a feature request :-).
One way which I described in the beginning if we do not store the module in the bookmark, is to use the last used module that does include the reference, if there is one. I realize this isn't perfect either.
bvahedy
commented
2 years ago Ok, sorry I didn't notice that.
didib
commented
2 years ago np :-)
tuomas2
commented
2 years ago I read just OP and this looks like valid feature request to me.
Not sure if it will be confusing to user to suddenly change document and which document should we change to is not obvious. When implementing, these should be addressed somehow. Perhaps should be option somewhere.
agrogers
commented
2 years ago It should change to the document in which the bookmark was created.
Maybe a toast message saying that the document was changed would be helpful too.
www.TenOutOfTen.org https://www.TenOutOfTen.org @.*** (+61) 0477 174 193 (Australia) (+95) 09 250018669 (Myanmar)
On Thu, 25 Nov 2021 at 17:43, Tuomas Airaksinen @.***> wrote:
I read just OP and this looks like valid feature request to me.
Not sure if it will be confusing to user to suddenly change document and which document should we change to is not obvious. When implementing, these should be addressed somehow. Perhaps should be option somewhere.
— You are receiving this because you commented. Reply to this email directly, view it on GitHub https://github.com/AndBible/and-bible/issues/1952#issuecomment-978915351, or unsubscribe https://github.com/notifications/unsubscribe-auth/ADKGTJWP4SM22Y57ACFHWWTUNXSKNANCNFSM5IL33OGA .
tuomas2
commented
2 years ago Maybe with toast it would be good/clear enough.
Hi all,
I am a long time user (~ 6 years?), and this is my first contribution here. Thanks a lot for a great project/program.
Is your feature request related to a problem? Please describe. I use andbible mostly in Hebrew, with MAPM and HebDelitzsch. Former is old-testament only, latter new-testament only. When I am in one of them, and move to a bookmark referencing the other, I get the "not found" message and have to switch books.
Describe the solution you'd like In the past, the bookmarks list didn't show at all the texts of "the other". Now, since some time ago, it does. Not sure how - perhaps the bookmark also remembers the book, or uses one that includes the reference, or something like that. It would be useful if when pressing a bookmark, if the reference is missing from the current book, it would automatically jump to a book containing it - perhaps the one in which the bookmark was created (if it's saved in the bookmark), or the last used book containing the reference, or even a new user option somewhere.
Describe alternatives you've considered I didn't - I just manually switch books
Additional context I guess this is relevant for others who often use languages where old and new testaments are split between books. Not sure which, though. In Hebrew, in particular, it seemed hard, at the time (~ 6 years ago), to create a single book with both old and new testaments, which follows each ones' current versification. Perhaps that's possible today, I didn't check in recent years.
I am the "maintainer" (lazy one) of HebDelitzsch.