search

AndBible / and-bible

AndBible: Bible Study
https://andbible.org
GNU General Public License v3.0
592 stars 197 forks source link

Other app language causes Bible link to show message "Please download Ge 1" #2147

Open timbze opened 2 years ago

timbze commented 2 years ago

https://support.andbible.org/scp/tickets.php?id=1396

Describe the bug Link from commentary can not open when app language is set to German.

Bug was found on And Bible version Build 643 standard release

To Reproduce Steps to reproduce the behavior:

  1. Set app language to German
  2. Open Gen 1:18 in KJV window 1
  3. Open Gill commentary for Gen 1:18 in window 2 (or anywhere)
  4. Try to open the first link in the commentary (Ge 1:16)
  5. Message says "Please download Ge 1"

It's important to note that many other links work, including "Ps 136:1/Ec 11:7" which is in the commentary further down from the same verse.

Screenshots image

tuomas2 commented 2 years ago

Hmm. OSIS produced by JSword is different depending on app language.

tuomas2 commented 2 years ago

JSword: BibleNames.java:114 (getBook) finds with fuzzy search (line 128) something wrong for "Ge" in German language, and such a key does not exist in bible module.

Not sure how to fix that. Perhaps should revert the order, such that english lookup is always first. But that could lead to other issues...

timbze commented 2 years ago

Perhaps should revert the order, such that english lookup is always first.

I have not looked at the details of what you're working with, so I may be off... but would it work to make it that the first lookup language would be the module language?

tuomas2 commented 2 years ago

You are right. We just should pass doc language information through quite many steps until it is used.

Selection_428

tuomas2 commented 2 years ago

Not very appealing thing to do from code point of view..