search

AndBible / and-bible

AndBible: Bible Study
https://andbible.org
GNU General Public License v3.0
589 stars 197 forks source link

Make option for 2 finger tap search and disable it by default #2464

Open tuomas2 opened 1 year ago

tuomas2 commented 1 year ago

2 finger tap search implemented in c67a45611dc4e394c6375ee0c97626f5ca9912a3

agrogers commented 1 year ago

Will do.

www.TenOutOfTen.org https://www.TenOutOfTen.org @.*** (+61) 0477 174 193 (Australia) (+95) 09 250018669 (Myanmar)

On Wed, 18 Jan 2023 at 00:58, Tuomas Airaksinen @.***> wrote:

c67a456 https://github.com/AndBible/and-bible/commit/c67a45611dc4e394c6375ee0c97626f5ca9912a3

— Reply to this email directly, view it on GitHub https://github.com/AndBible/and-bible/issues/2464#issuecomment-1385851562, or unsubscribe https://github.com/notifications/unsubscribe-auth/ADKGTJQE3P3AAWHO5I3L4UTWS3QGPANCNFSM6AAAAAAT6F4RCI . You are receiving this because you were assigned.Message ID: @.***>

tuomas2 commented 1 year ago

If implementing this, first revert b5cdd1cc0fe7945710891dd6fabdf1e42196d9f4 and then implement optionality.

agrogers commented 1 year ago

I thought of another way of implementing this as well. But that change is bigger but maybe more beautiful. The MyBible highlighting method gave me the idea. I will make up a mock up of it at some point.

www.TenOutOfTen.org https://www.TenOutOfTen.org @.*** (+61) 0477 174 193 (Australia) (+95) 09 250018669 (Myanmar)

On Thu, 23 Mar 2023 at 13:35, Tuomas Airaksinen @.***> wrote:

If implementing this, first revert b5cdd1c https://github.com/AndBible/and-bible/commit/b5cdd1cc0fe7945710891dd6fabdf1e42196d9f4 and then implement optionality.

— Reply to this email directly, view it on GitHub https://github.com/AndBible/and-bible/issues/2464#issuecomment-1480695665, or unsubscribe https://github.com/notifications/unsubscribe-auth/ADKGTJTDHXXFNLLU3PEKYRDW5PY3NANCNFSM6AAAAAAT6F4RCI . You are receiving this because you were assigned.Message ID: @.***>